Skip to content

refactor: dcr integration with ims-go after moving logics#106

Merged
telegrapher merged 17 commits intoadobe:mainfrom
Eiermitsucuk:main
Apr 9, 2026
Merged

refactor: dcr integration with ims-go after moving logics#106
telegrapher merged 17 commits intoadobe:mainfrom
Eiermitsucuk:main

Conversation

@Eiermitsucuk
Copy link
Copy Markdown
Contributor

Description

Integrate DCR (Dynamic Client Registration) with ims-go library and add scope support.

Related Issue

Follows ims-go PR that added DCR implementation and scope support.

How Has This Been Tested?

  • Ran go build ./... and go test ./... — all tests pass
  • Verified DCR command works with scopes: imscli dcr register --clientName "app" --redirectURIs "http://localhost:8888" --scopes "openid,AdobeID"
  • Verified DCR works without scopes (backward compatible)
  • Tested integration with authz and OBO commands using the registered client credentials
  • All existing integration tests pass

Types of changes

  • New feature
  • Refactoring

cmd/dcr.go Outdated
Short: "Register a client.",
Long: `Register a new OAuth client using Dynamic Client Registration.`,
RunE: func(cmd *cobra.Command, args []string) error {
RunE: func(cmd *cobra.Command, asrgs []string) error {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args is good

@telegrapher telegrapher merged commit b1f3d1e into adobe:main Apr 9, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants