-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: dcr integration with ims-go after moving logics #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
27f59b2
fix: clean up after migrating obo logic to ims-go
Eiermitsucuk d348816
refactor: trying the refactoring with github repository
Eiermitsucuk 855a662
fix: go.mod
Eiermitsucuk 7a8d2a9
fix: go.mod
Eiermitsucuk b90a8b2
fix: small resolves related to pr
Eiermitsucuk d43a3c6
fix: obo_exchange.go
Eiermitsucuk e6bc7bf
Merge pull request #3 from adobe/main
Eiermitsucuk b0f59f4
refactor: cleaning up after moving the dcr logic to ims-go
Eiermitsucuk 6df9e76
feat: added scopes
Eiermitsucuk ad27554
fix: go.mod
Eiermitsucuk a2e07a8
fix: demo
Eiermitsucuk e6a0a7c
fix: go.mod
Eiermitsucuk 3f35796
Merge branch 'main' into main
Eiermitsucuk ffd01b2
gitignore
Eiermitsucuk 76757df
fix: removed demo
Eiermitsucuk 18aa8d0
refactor: unused constants were removed
Eiermitsucuk 2cd0f99
fix: syntax in dcr.go
Eiermitsucuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Copyright 2026 Adobe. All rights reserved. | ||
| // This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. You may obtain a copy | ||
| // of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software distributed under | ||
| // the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| // OF ANY KIND, either express or implied. See the License for the specific language | ||
| // governing permissions and limitations under the License. | ||
|
|
||
| // Dynamic Client Registration (DCR): POST JSON to IMS /ims/register. | ||
|
|
||
| package ims | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/adobe/ims-go/ims" | ||
| ) | ||
|
|
||
| func (i Config) validateDCRConfig() error { | ||
| switch { | ||
| case i.URL == "": | ||
| return fmt.Errorf("missing IMS base URL parameter") | ||
| case !validateURL(i.URL): | ||
| return fmt.Errorf("invalid IMS base URL parameter") | ||
| case i.ClientName == "": | ||
| return fmt.Errorf("missing client name parameter") | ||
| case len(i.RedirectURIs) == 0: | ||
| return fmt.Errorf("missing redirect URIs parameter") | ||
| default: | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| func (i Config) DCRRegister() (string, error) { | ||
| if err := i.validateDCRConfig(); err != nil { | ||
| return "", fmt.Errorf("invalid parameters for client registration: %w", err) | ||
| } | ||
|
|
||
| c, err := i.newIMSClient() | ||
| if err != nil { | ||
| return "", fmt.Errorf("error creating the IMS client: %w", err) | ||
| } | ||
|
|
||
| resp, err := c.DCR(&ims.DCRRequest{ | ||
| ClientName: i.ClientName, | ||
| RedirectURIs: i.RedirectURIs, | ||
| Scopes: i.Scopes, | ||
| }) | ||
| if err != nil { | ||
| return "", fmt.Errorf("error during client registration: %w", err) | ||
| } | ||
|
|
||
| return string(resp.Body), nil | ||
| } |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args is good