Improve clarity of layer benefits in documentation#5806
Open
thatguyjk wants to merge 1 commit intoaframevr:masterfrom
Open
Improve clarity of layer benefits in documentation#5806thatguyjk wants to merge 1 commit intoaframevr:masterfrom
thatguyjk wants to merge 1 commit intoaframevr:masterfrom
Conversation
Clarified the explanation of visual fidelity and battery life benefits by correcting sampling descriptions and punctuation.
There was a problem hiding this comment.
Pull request overview
This PR updates the layer component documentation to clarify the “visual fidelity” and “battery life” benefits by correcting the sampling description and improving punctuation for readability.
Changes:
- Fixes a typo/wording issue in the “Visual fidelity” sampling explanation (“Once when rendering…”).
- Adds punctuation to improve readability in the “Battery life” bullet.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
+18
| - **Performance and judder:** Once the layer is submitted, the compositor is in charge of render it at a fixed refresh rate (72Hz, 90Hz... depending on device). Even if the application cannot keep up with the compositor refresh rate the layer won't drop any frames resulting in a smoother experience. | ||
| - **Visual fidelity:** The images in a layer will be sampled only once by the compositor. Regular WebGL content is sampled twice: Once one rendering to the eye buffer and a second time when copied to the compositor. This results in a loss of details. | ||
| - **Battery life:** No double sampling results in less memory copies reducing operations and battery consumption. | ||
| - **Visual fidelity:** The images in a layer will be sampled only once by the compositor. Regular WebGL content is sampled twice: Once when rendering to the eye buffer and a second time when copied to the compositor. This results in a loss of details. | ||
| - **Battery life:** No double sampling results in less memory copies, reducing operations and battery consumption. |
There was a problem hiding this comment.
A few remaining grammar/wording issues in this list reduce clarity:
- "in charge of render it" should be "in charge of rendering it".
- "loss of details" reads more naturally as "loss of detail".
- "less memory copies" should be "fewer memory copies" (countable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarified the explanation of visual fidelity and battery life benefits by correcting sampling descriptions and punctuation.
Description:
Changes proposed: