Skip to content

Replaces #297 - Add wallet labels, display master fingerprint, fix Windows build and Sonar issues#299

Open
pauloneo wants to merge 7 commits into
airgap-it:masterfrom
pauloneo:pr297-sonar
Open

Replaces #297 - Add wallet labels, display master fingerprint, fix Windows build and Sonar issues#299
pauloneo wants to merge 7 commits into
airgap-it:masterfrom
pauloneo:pr297-sonar

Conversation

@pauloneo

Copy link
Copy Markdown

This PR includes three improvements.

  1. Windows build fix
    Problem
    The Android build generated an invalid public/assets/protocol_modules structure on Windows because the namespace was extracted using module.path.split('/'), which does not work with Windows path separators ().

Solution
Replaced the namespace extraction with path.basename(module.path), which works correctly on both Windows and Linux.

  1. Master Fingerprint display
    Problem
    When multiple wallets are created from the same mnemonic using different BIP-39 passphrases, users cannot easily verify which wallet they are viewing.

Solution
Display the wallet Master Fingerprint on the account details screen, allowing users to verify the correct wallet.

  1. Custom wallet labels
    Problem
    When multiple accounts use the same protocol (for example several Bitcoin SegWit wallets), the account list only displays the protocol name and address, making it difficult to distinguish them.

Solution
Added support for custom wallet labels:

enter a label when creating a wallet;
persist the label during wallet serialization;
restore the label when deserializing the wallet;
display the label in the account list below the protocol name.

@pauloneo pauloneo changed the title Pr297 sonar Pr297 (PR with Sonar correction included) Jul 15, 2026
@sonarqubecloud

Copy link
Copy Markdown

@pauloneo pauloneo changed the title Pr297 (PR with Sonar correction included) Pr297 (PR with Sonar correction included) - Add wallet labels, display master fingerprint and fix Windows build Jul 15, 2026
@pauloneo pauloneo changed the title Pr297 (PR with Sonar correction included) - Add wallet labels, display master fingerprint and fix Windows build Replaces #297 - Add wallet labels, display master fingerprint, fix Windows build and Sonar issues Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant