Replaces #297 - Add wallet labels, display master fingerprint, fix Windows build and Sonar issues#299
Open
pauloneo wants to merge 7 commits into
Open
Replaces #297 - Add wallet labels, display master fingerprint, fix Windows build and Sonar issues#299pauloneo wants to merge 7 commits into
pauloneo wants to merge 7 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR includes three improvements.
Problem
The Android build generated an invalid public/assets/protocol_modules structure on Windows because the namespace was extracted using module.path.split('/'), which does not work with Windows path separators ().
Solution
Replaced the namespace extraction with path.basename(module.path), which works correctly on both Windows and Linux.
Problem
When multiple wallets are created from the same mnemonic using different BIP-39 passphrases, users cannot easily verify which wallet they are viewing.
Solution
Display the wallet Master Fingerprint on the account details screen, allowing users to verify the correct wallet.
Problem
When multiple accounts use the same protocol (for example several Bitcoin SegWit wallets), the account list only displays the protocol name and address, making it difficult to distinguish them.
Solution
Added support for custom wallet labels:
enter a label when creating a wallet;
persist the label during wallet serialization;
restore the label when deserializing the wallet;
display the label in the account list below the protocol name.