feat: add functionality to helm-update-chart to match on an alias#5902
feat: add functionality to helm-update-chart to match on an alias#5902aaron-lunsford-even wants to merge 1 commit intoakuity:mainfrom
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Aaron Lunsford <aaron.lunsford@one.app>
aaron-lunsford-even
force-pushed
the
aaron-lunsford-even/issue-5891-01
branch
from
e473f6e to
b9b23cd
Compare
aaron-lunsford-even
changed the title
| @@ -19,6 +19,7 @@ referenced by the Freight being promoted. This step is commonly followed by a | |||
| | `charts` | `[]object` | N | The details of dependency (subchart) updates to be applied to the chart's `Chart.yaml` file. When left unspecified, charts will be updated according to the SemVer ranges declared in the `Chart.yaml` file. | | |||
| | `charts[].repository` | `string` | Y | The URL of the Helm chart repository in the `dependencies` entry whose `version` field is to be updated. Must _exactly_ match the `repository` field of that entry. | | |||
| | `charts[].name` | `string` | Y | The name of the chart in in the `dependencies` entry whose `version` field is to be updated. Must exactly match the `name` field of that entry. | | |||
There was a problem hiding this comment.
Is name now optional? Appears to be mutually exclusive with alias. Can't you always match on name in addition to alias? Could you give a couple of examples in the description?
There was a problem hiding this comment.
Helm uses repository + name together as the full identifier for a chart.
The right thing here would be to have the repository + name pair mutually exclusive with alias.
There was a problem hiding this comment.
pkg/promotion/runner/builtin/schemas/helm-update-chart-config.json would be the right place to codify that.
Then you need to run make hack-codegen to re-generate step configuration from that modified schema.
Then pkg/promotion/runner/builtin/helm_chart_updater.go needs changes to propagate the new configuration option down to the lower level code you already modified.
I'm going to change this to a draft for now.
krancour
added
kind/enhancement
|
I have this in the v1.10.0 milestone, but that's only tentative. |
|
@aaron-lunsford-even were you intending to continue on this PR or should I close it? |
3 participants
Closes #5891
Implements a new
aliasoption to thehelm-update-chartstep that allows matching on a chart dependency'saliasfield.