feat: BB client gen (for cloud + server) + merge strategy support#6128
feat: BB client gen (for cloud + server) + merge strategy support#6128
Conversation
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
==========================================
+ Coverage 57.67% 57.91% +0.23%
==========================================
Files 474 475 +1
Lines 40506 40822 +316
==========================================
+ Hits 23362 23642 +280
- Misses 15749 15775 +26
- Partials 1395 1405 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| paths=./... | ||
|
|
||
| .PHONY: codegen-bitbucket-client | ||
| codegen-bitbucket-client: install-oapi-codegen |
There was a problem hiding this comment.
We were already using go-swagger for generating the client for our own APIs. I'm open to using something else, such as this, but ideally we wouldn't use two different tools for the same purpose.
Did you happen to try either generating the BB client using go-swagger or, inversely, try generating our own client using oapi-codegen?
There was a problem hiding this comment.
The two tools target different spec versions and are not interchangeable here.go-swagger only supports Swagger 2.0 (OAS2) specs. The Bitbucket Cloud API spec is OpenAPI 3.0 (OAS3),
|
I think there are some things to discuss here still, but I am really happy to see that generating a BB client and using that appears tenable. |
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
|
@krancour so far we are able to:
This obviously needs a lot of end-to-end testing. Per our offline discussion I have sub-packages:
Implemented each with their own individual registration predicate. |
|
I can take this out of draft and start end-to-end testing unless there's something else we still want to discuss? |
Signed-off-by: fuskovic <fhuskovic92@gmail.com>
github.com/ktrysmt/go-bitbucketdependency.codegen-bitbucket-clientMakefile target (backed by oapi-codegen pinned in hack/tools/) so the generated client can be regenerated in one command.git-merge-prdocs to list the supported Bitbucket merge methods now that the generated enum makes them explicit.Closes: #6023
Closes: #6022
Closes: #6020