-
Notifications
You must be signed in to change notification settings - Fork 362
feat: BB client gen (for cloud + server) + merge strategy support #6128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 8 commits
72fd991
2dffb75
7dc007a
5e2c1e4
e0f4bf3
cd6dbbb
b58463d
db875ce
e3f1b62
fdd9093
91de519
412ded4
49ce9b9
6646ef9
76b46ed
4ae10c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ build-cli-with-ui: build-ui build-cli | |
| ################################################################################ | ||
|
|
||
| .PHONY: codegen | ||
| codegen: codegen-openapi codegen-proto codegen-controller codegen-schema-to-go codegen-ui codegen-docs | ||
| codegen: codegen-openapi codegen-proto codegen-controller codegen-schema-to-go codegen-bitbucket-client codegen-ui codegen-docs | ||
|
|
||
| .PHONY: codegen-openapi | ||
| codegen-openapi: install-swag install-go-swagger install-jq | ||
|
|
@@ -259,6 +259,10 @@ codegen-controller: install-controller-gen | |
| object:headerFile=hack/boilerplate.go.txt \ | ||
| paths=./... | ||
|
|
||
| .PHONY: codegen-bitbucket-client | ||
| codegen-bitbucket-client: install-oapi-codegen | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We were already using go-swagger for generating the client for our own APIs. I'm open to using something else, such as this, but ideally we wouldn't use two different tools for the same purpose. Did you happen to try either generating the BB client using go-swagger or, inversely, try generating our own client using oapi-codegen?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The two tools target different spec versions and are not interchangeable here. |
||
| cd pkg/gitprovider/bitbucket && $(OAPI_CODEGEN_LINK) --config spec/oapi-codegen.yaml spec/bitbucket.gen.json | ||
|
|
||
| .PHONY: codegen-schema-to-go | ||
| codegen-schema-to-go: install-goimports | ||
| npm install -g quicktype@23.0.176 | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.