Skip to content

Don't use builtin LZMA#6201

Open
singiamtel wants to merge 7 commits intoalisw:masterfrom
singiamtel:newroot+nobuiltinlzma
Open

Don't use builtin LZMA#6201
singiamtel wants to merge 7 commits intoalisw:masterfrom
singiamtel:newroot+nobuiltinlzma

Conversation

@singiamtel
Copy link
Copy Markdown
Collaborator

@singiamtel singiamtel commented Apr 1, 2026 •
edited
Loading

Don't use builtin LZMA

@singiamtel singiamtel requested a review from a team as a code owner April 1, 2026 10:49
ktf
ktf previously approved these changes Apr 1, 2026
View reviewed changes
@singiamtel
Copy link
Copy Markdown
Collaborator Author

singiamtel commented Apr 1, 2026 

-- Could NOT find LibLZMA (missing: LIBLZMA_INCLUDE_DIR) 
-- LZMA not found. Switching on builtin_lzma option

Well, this seems like a pretty aggressive default by ROOT. I'll specify this variable too

@singiamtel
Copy link
Copy Markdown
Collaborator Author

singiamtel commented Apr 1, 2026 

/Volumes/build/alice-ci-workdir/alidist-o2_staging/sw/SOURCES/O2/6201/0/Common/Field/src/MagFieldParam.cxx:101:14: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
  101 |   char cbuff[lgt + 2];
      |              ^~~~~~~

Not sure why this happens, I thought it'd be fixed by the new ROOT

@singiamtel singiamtel requested a review from a team as a code owner April 2, 2026 12:09
@singiamtel singiamtel force-pushed the newroot+nobuiltinlzma branch from b9b5726 to a98bcda Compare April 2, 2026 13:17
vkucera
vkucera reviewed Apr 7, 2026
View reviewed changes
Comment thread o2.sh Outdated
@singiamtel singiamtel force-pushed the newroot+nobuiltinlzma branch 4 times, most recently from a714306 to 2f00561 Compare April 22, 2026 13:42
@singiamtel singiamtel force-pushed the newroot+nobuiltinlzma branch from 2f00561 to 4f2a296 Compare April 23, 2026 10:53
@ktf ktf mentioned this pull request Apr 23, 2026
Open
ktf
ktf reviewed Apr 30, 2026
View reviewed changes
Comment thread root.sh Outdated
@ktf
Apply suggestions from code review
6d36a46 
Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com>
vkucera
vkucera previously approved these changes May 5, 2026
View reviewed changes
vkucera
vkucera reviewed May 5, 2026
View reviewed changes
Comment thread root.sh
vkucera
vkucera reviewed May 5, 2026
View reviewed changes
Comment thread root.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktf ktf ktf left review comments

@vkucera vkucera vkucera left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@singiamtel @ktf @vkucera