Skip to content

Don't use builtin LZMA #6201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singiamtel wants to merge 7 commits into
base: master
Choose a base branch
from
+6 −0
Open

Don't use builtin LZMA #6201

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e39b647
No builtin LZMA
singiamtel Apr 1, 2026
4f2a296
Properly take LZMA from system on macos
singiamtel Apr 23, 2026
96b486e
Proper LZMA variables
singiamtel Apr 23, 2026
ac6cc51
Disable vla extension warning
singiamtel Apr 23, 2026
6d36a46
Apply suggestions from code review
ktf Apr 30, 2026
42064cc
Dummy commit to restart CI
vkucera May 5, 2026
fa3b891
Dummy commit to restart CI
vkucera May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions root.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@
[[ ! $GSL_ROOT ]] && GSL_ROOT=$(brew --prefix gsl)
[[ ! $OPENSSL_ROOT ]] && SYS_OPENSSL_ROOT=$(brew --prefix openssl@3)
[[ ! $LIBPNG_ROOT ]] && LIBPNG_ROOT=$(brew --prefix libpng)
[[ ! $LZMA_ROOT ]] && LZMA_ROOT=$(brew --prefix xz)

Check notice on line 92 in root.sh

View workflow job for this annotation

GitHub Actions / alidistlint 

Prefer explicit -n to check non-empty string (or use =/-ne to check boolean/integer). [SC2244]
EXTRA_CMAKE_CXX_FLAGS="-Wno-vla-cxx-extension"
Comment thread
ktf marked this conversation as resolved.
Outdated
;;
esac

Expand Down Expand Up @@ -141,6 +143,7 @@
cmake $SOURCEDIR \
${CMAKE_GENERATOR:+-G "$CMAKE_GENERATOR"} \
-DCMAKE_BUILD_TYPE=$CMAKE_BUILD_TYPE \
${EXTRA_CMAKE_CXX_FLAGS:+-DCMAKE_CXX_FLAGS="${EXTRA_CMAKE_CXX_FLAGS}"} \
-DCMAKE_INSTALL_PREFIX=$INSTALLROOT \
-Dalien=OFF \
${CMAKE_CXX_STANDARD:+-DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}} \
Expand Down Expand Up @@ -170,6 +173,8 @@
${LIBPNG_ROOT:+-DPNG_LIBRARY="${LIBPNG_ROOT}/lib/libpng.${SONAME}"} \
${PROTOBUF_REVISION:+-DProtobuf_DIR=${PROTOBUF_ROOT}} \
${ZLIB_ROOT:+-DZLIB_ROOT=${ZLIB_ROOT}} \
${LZMA_ROOT:+-DLIBLZMA_INCLUDE_DIR=${LZMA_ROOT}/include} \
${LZMA_ROOT:+-DLIBLZMA_LIBRARY=${LZMA_ROOT}/lib/liblzma.${SONAME}} \
${FFTW3_ROOT:+-DFFTW_DIR=${FFTW3_ROOT}} \
${NLOHMANN_JSON_ROOT:+nlohmann_json_DIR=${NLOHMANN_JSON_ROOT}} \
-Dfftw3=ON \
Expand All @@ -188,6 +193,7 @@
-Dgviz=OFF \
-Dbuiltin_davix=OFF \
-Dbuiltin_fftw3=OFF \
-Dbuiltin_lzma=OFF \
-Dtmva-sofie=ON \
-Dtmva-gpu=OFF \
-Ddavix=OFF \
Expand Down
Loading