Fix yaml version check - #200
Open
haarg wants to merge 2 commits into
Open
Conversation
A v prefix is meaningful in perl versions, so it can be misleading to add a v. And for modules using a version that includes a v, it would display starting with two vs.
Checking versions should be done using the ->VERSION method. New versions of YAML are using three part versions, so checking with a numeric comparison won't work correctly.
Author
|
Fixes RT#180176 |
perlpunk
reviewed
Jul 22, 2026
| $CPAN::Shell::reload->{$file} = $mtime; | ||
| my $v = eval "\$$mod\::VERSION"; | ||
| $v = $v ? " (v$v)" : ""; | ||
| $v = $v ? " ($v)" : ""; |
Contributor
There was a problem hiding this comment.
Now will this still work as expected if YAML.pm goes back to decimal, which I'm intending to do? This is just informal output, right?
Contributor
There was a problem hiding this comment.
Yes, it was wrong regardless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.