Skip to content

Fix yaml version check #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haarg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix yaml version check #200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af96092
don't add v prefix when displaying version after loading module
haarg Jul 20, 2026
7b6c706
check YAML version using VERSION method
haarg Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/CPAN.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ sub _yaml_module () {
&&
$CPAN::META->has_inst($yaml_module)
&&
$YAML::VERSION < 0.60
!eval { YAML->VERSION(0.60) }
&&
!$Have_warned->{"YAML"}++
) {
Expand Down Expand Up @@ -1255,7 +1255,7 @@ sub has_inst {
# as a proxy for a checksum.
$CPAN::Shell::reload->{$file} = $mtime;
my $v = eval "\$$mod\::VERSION";
$v = $v ? " (v$v)" : "";
$v = $v ? " ($v)" : "";

@perlpunk perlpunk Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now will this still work as expected if YAML.pm goes back to decimal, which I'm intending to do? This is just informal output, right?

@Grinnz Grinnz Jul 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was wrong regardless

CPAN::Shell->optprint("load_module","CPAN: $mod loaded ok$v\n");
if ($mod eq "CPAN::WAIT") {
push @CPAN::Shell::ISA, 'CPAN::WAIT';
Expand Down