AAP-46484 Capture k8s pod diagnostics - #1332
Closed
arrestle wants to merge 67 commits into
Closed
Conversation
arrestle
marked this pull request as draft
June 2, 2025 18:26
arrestle
force-pushed
the
capture-k8s-pod-diagnostics
branch
from
June 3, 2025 20:26
bc6839f to
a56b3a7
Compare
lranjbar
suggested changes
Jun 6, 2025
lranjbar
left a comment
lranjbar
left a comment
Contributor
There was a problem hiding this comment.
Looking good! Just some feedback on these :)
arrestle
force-pushed
the
capture-k8s-pod-diagnostics
branch
from
June 6, 2025 19:29
78448c9 to
4ad6fde
Compare
arrestle
force-pushed
the
capture-k8s-pod-diagnostics
branch
from
June 6, 2025 19:38
4ad6fde to
55b3047
Compare
arrestle
changed the title
Collaborator
|
When a pod fails because the ephemeral-storage is over the limit I'm getting these error logs: I do see OOMKilled when the pod fails because of an OOMKill |
PabloHiro
force-pushed
the
capture-k8s-pod-diagnostics
branch
from
June 10, 2025 10:59
cb9a50b to
49afc98
Compare
PabloHiro
requested changes
Jun 10, 2025
added 5 commits
June 10, 2025 08:12
arrestle
marked this pull request as ready for review
June 10, 2025 13:43
PabloHiro
reviewed
Jun 10, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## devel #1332 +/- ##
==========================================
- Coverage 51.60% 51.52% -0.09%
==========================================
Files 59 63 +4
Lines 9826 10491 +665
==========================================
+ Hits 5071 5405 +334
- Misses 4451 4776 +325
- Partials 304 310 +6
... and 9 files with indirect coverage changes
🚀 New features to boost your workflow:
|
arrestle
marked this pull request as draft
June 23, 2025 20:46
PabloHiro
requested changes
Jun 24, 2025
PabloHiro
approved these changes
Jun 30, 2025
PabloHiro
left a comment
PabloHiro
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the hard work!
|
arrestle
marked this pull request as ready for review
July 2, 2025 18:52
davemulford
approved these changes
Jul 3, 2025
davemulford
left a comment
davemulford
left a comment
Contributor
There was a problem hiding this comment.
Reviewed during a 1:1 call, talked through some of the testing methods. Looks great!
AaronH88
reviewed
Jul 3, 2025
| podName, | ||
| ) | ||
|
|
||
| // timeout := int64(10) |
Contributor
There was a problem hiding this comment.
Take out commented out code please,
The tests are enough for now
Author
AaronH88
reviewed
Jul 3, 2025
| } | ||
|
|
||
| // only transition from WorkStateRunning to WorkStateSucceeded if WorkStateFailed is set we do not override | ||
| // pod, err := kw.KubeAPIWrapperInstance.Get(kw.GetContext(), kw.clientset, podNamespace, podName, metav1.GetOptions{}) |
Contributor
There was a problem hiding this comment.
same as above
Take out commented out code please,
The tests are enough for now
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect a pod failure caused by OOMKilled or other infrastructure related error.
This one outputs:
Note we have a new PR 1368 for CapturePodStatus