AAP-46619 Get pod container status - #1371
Merged
Merged
Conversation
added 3 commits
July 3, 2025 14:52
Reorder to be define before use
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## devel #1371 +/- ##
==========================================
+ Coverage 52.06% 54.10% +2.04%
==========================================
Files 59 63 +4
Lines 9826 10475 +649
==========================================
+ Hits 5116 5668 +552
- Misses 4395 4506 +111
+ Partials 315 301 -14
... and 10 files with indirect coverage changes
🚀 New features to boost your workflow:
|
PabloHiro
approved these changes
Jul 4, 2025
AaronH88
reviewed
Jul 4, 2025
AaronH88
reviewed
Jul 4, 2025
AaronH88
reviewed
Jul 4, 2025
Contributor
|
Mostly this looks great and thanks so much for all the hard work on it so far. I think some complexity could be reduced and I question 1 function. But thank you so much for reducing the size of this change and making it possible to do a good code review! |
lranjbar
suggested changes
Jul 7, 2025
Co-authored-by: Lisa Ranjbar Miller <lethalsneeze@gmail.com>
AaronH88
reviewed
Jul 8, 2025
AaronH88
reviewed
Jul 8, 2025
AaronH88
reviewed
Jul 8, 2025
AaronH88
reviewed
Jul 8, 2025
AaronH88
reviewed
Jul 8, 2025
AaronH88
reviewed
Jul 8, 2025
lranjbar
approved these changes
Jul 8, 2025
|
AaronH88
approved these changes
Jul 9, 2025
AaronH88
left a comment
Contributor
There was a problem hiding this comment.
lgtm,
as soon as everything passes feel free to hit the button 🕺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request addresses concerns about the size and commit history of PR #1332. We are consolidating these helper functions in this PR and moving the WaitForPodCompleted function to a separate pull request.
PodHealthy - Determine if the Pod and Container are both healthy. Eventually to be called after WaitForBodCompleted function determines the Pod has "settled" into a state that has diagnostic information.
PodContainerHealthy - Typically called by PodHealthy to make sure the "worker" container is healthy but can also be invoked externally.