Skip to content

AAP-46619 Get pod container status - #1371

Merged
AaronH88 merged 13 commits into
ansible:develfrom
arrestle:get-pod-container-status
Jul 9, 2025
Merged

AAP-46619 Get pod container status#1371
AaronH88 merged 13 commits into
ansible:develfrom
arrestle:get-pod-container-status

Conversation

@arrestle

@arrestle arrestle commented Jul 3, 2025

Copy link
Copy Markdown

This pull request addresses concerns about the size and commit history of PR #1332. We are consolidating these helper functions in this PR and moving the WaitForPodCompleted function to a separate pull request.

  1. PodHealthy - Determine if the Pod and Container are both healthy. Eventually to be called after WaitForBodCompleted function determines the Pod has "settled" into a state that has diagnostic information.

  2. PodContainerHealthy - Typically called by PodHealthy to make sure the "worker" container is healthy but can also be invoked externally.

@arrestle arrestle changed the title Get pod container status AAP-46619 Get pod container status Jul 3, 2025
@codecov

codecov Bot commented Jul 3, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.08197% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.10%. Comparing base (d1a82cc) to head (113c23b).
⚠️ Report is 43 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/kubernetes.go 66.66% 2 Missing ⚠️
pkg/workceptor/pod.go 98.18% 1 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1371      +/-   ##
==========================================
+ Coverage   52.06%   54.10%   +2.04%     
==========================================
  Files          59       63       +4     
  Lines        9826    10475     +649     
==========================================
+ Hits         5116     5668     +552     
- Misses       4395     4506     +111     
+ Partials      315      301      -14     
Files with missing lines Coverage Δ
pkg/workceptor/pod.go 98.18% <98.18%> (ø)
pkg/workceptor/kubernetes.go 52.46% <66.66%> (+8.65%) ⬆️

... and 10 files with indirect coverage changes

Components Coverage Δ
Go 54.39% <95.08%> (+2.32%) ⬆️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread pkg/workceptor/pod.go Outdated
Comment thread pkg/workceptor/pod.go Outdated
Comment thread pkg/workceptor/pod.go Outdated
@AaronH88

AaronH88 commented Jul 4, 2025

Copy link
Copy Markdown
Contributor

Mostly this looks great and thanks so much for all the hard work on it so far.

I think some complexity could be reduced and I question 1 function. But thank you so much for reducing the size of this change and making it possible to do a good code review!

Comment thread pkg/workceptor/pod_test.go Outdated
Comment thread pkg/workceptor/pod.go Outdated
Comment thread pkg/workceptor/pod.go Outdated
Comment thread go.mod Outdated
Comment thread pkg/workceptor/pod.go Outdated
Comment thread pkg/workceptor/pod.go Outdated
Comment thread pkg/workceptor/pod_test.go

@AaronH88 AaronH88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close, 🕺

@arrestle
arrestle requested a review from AaronH88 July 8, 2025 18:15
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

@AaronH88 AaronH88 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

as soon as everything passes feel free to hit the button 🕺

@AaronH88
AaronH88 merged commit 15f223c into ansible:devel Jul 9, 2025
24 checks passed
@arrestle
arrestle deleted the get-pod-container-status branch July 9, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants