[BRANCH-52] fix: foreign inner ffi types#21439
Merged
alamb merged 2 commits intoapache:branch-52from Apr 7, 2026
Merged
Conversation
timsaucer
changed the title
11 tasks
alamb
approved these changes
Apr 7, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
I think it would be good to add a test if possible. However this also seems fine and a safe backport
Contributor
|
@timsaucer is this one ready to review / merge? |
Member
Author
|
Yes, I think it's very safe to merge in |
Contributor
|
Ok, I'll merge this one in and make a RC |
Contributor
|
Thanks @timsaucer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This fixes a regression on using foreign schema + catalog + table providers.
What changes are included in this PR?
Check for existing Foreign types, and get their inner FFI type if available.
Are these changes tested?
Tested internally at rerun in production. Also code is backported from df-53
Are there any user-facing changes?
None