Skip to content

[BRANCH-52] fix: foreign inner ffi types #21439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 2 commits into from
Apr 7, 2026
+13 −0
Merged

[BRANCH-52] fix: foreign inner ffi types #21439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b546b9
Check foreign table provider when creating ffi provider
timsaucer Mar 25, 2026
a8c6673
Check foreign catalog and schema provider when creating ffi versions
timsaucer Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datafusion/ffi/src/catalog_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,11 @@ impl FFI_CatalogProvider {
runtime: Option<Handle>,
logical_codec: FFI_LogicalExtensionCodec,
) -> Self {
if let Some(provider) = provider.as_any().downcast_ref::<ForeignCatalogProvider>()
{
return provider.0.clone();
}

let private_data = Box::new(ProviderPrivateData { provider, runtime });

Self {
Expand Down
5 changes: 5 additions & 0 deletions datafusion/ffi/src/schema_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,11 @@ impl FFI_SchemaProvider {
runtime: Option<Handle>,
logical_codec: FFI_LogicalExtensionCodec,
) -> Self {
if let Some(provider) = provider.as_any().downcast_ref::<ForeignSchemaProvider>()
{
return provider.0.clone();
}

let owner_name = provider.owner_name().map(|s| s.into()).into();
let private_data = Box::new(ProviderPrivateData { provider, runtime });

Expand Down
3 changes: 3 additions & 0 deletions datafusion/ffi/src/table_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,9 @@ impl FFI_TableProvider {
runtime: Option<Handle>,
logical_codec: FFI_LogicalExtensionCodec,
) -> Self {
if let Some(provider) = provider.as_any().downcast_ref::<ForeignTableProvider>() {
return provider.0.clone();
}
let private_data = Box::new(ProviderPrivateData { provider, runtime });

Self {
Expand Down
Loading