Add unit tests for JDBCEventQueryDAO, JDBCBrowserLogQueryDAO, and JDBCProfileThreadSnapshotQueryDAO#13802
Merged
wu-sheng merged 6 commits intoapache:masterfrom Apr 8, 2026
Merged
Conversation
wu-sheng
added
the
test
There was a problem hiding this comment.
Pull request overview
Adds JUnit tests to validate JDBCEventQueryDAO.buildQuery() SQL condition and parameter construction, improving regression protection for JDBC event querying.
Changes:
- Introduce
JDBCEventQueryDAOTestcovering mandatory TABLE_COLUMN discriminator behavior. - Add test cases for optional filters (UUID, source/service fields, event type).
- Verify TABLE_COLUMN discriminator isn’t duplicated when additional filters are present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...a/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCEventQueryDAOTest.java
Show resolved
Hide resolved
...a/org/apache/skywalking/oap/server/storage/plugin/jdbc/common/dao/JDBCEventQueryDAOTest.java
Show resolved
Hide resolved
currenjin
changed the title
wu-sheng
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR about?
Adds unit tests for three more JDBC query DAOs to improve test coverage in the storage-jdbc-hikaricp plugin.
JDBCEventQueryDAOTest— verifiesbuildQuery()condition/parameter building (TABLE_COLUMN, uuid, source, eventType)JDBCBrowserLogQueryDAOTest— verifiesbuildSQL()condition building (TABLE_COLUMN, serviceId, versionId, pagePathId, category, duration, limit)JDBCProfileThreadSnapshotQueryDAOTest— verifiesquerySegments()SQL structure (TABLE_COLUMN, taskId filter, sequence=0 filter)Which issue does this PR relate to?
N/A — test coverage improvement for JDBC storage plugin.
Tests
All new. 17 test cases total, all passing locally.