Skip to content

Fix bug caching requests with pyvo request_hooks#3586

Open
emellega wants to merge 1 commit intoastropy:mainfrom
emellega:fix-issue-with-caching
Open

Fix bug caching requests with pyvo request_hooks#3586
emellega wants to merge 1 commit intoastropy:mainfrom
emellega:fix-issue-with-caching

Conversation

@emellega
Copy link
Copy Markdown
Contributor

@emellega emellega commented May 4, 2026

When we migrated the ESASky module to use EsaTap/PyVO we noticed some weird errors for some of our requests that we didn't have before. When downloading images through the ESASky module we got Pyvo errors saying that we didn't conform to the TAP spec. It turns out that when we do a deep copy on the response (which contains the request hooks) during caching, it triggers something within Pyvo to do that validation.

I guess this is more of a workaround around something that is broken within pyvo rather than an actual bug fix. Let me know if you find this acceptable, or if you would rather see a proper fix within pyvo.

@emellega emellega force-pushed the fix-issue-with-caching branch from 0e21009 to ae746f1 Compare May 4, 2026 07:58
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.22%. Comparing base (a1fee2a) to head (ae746f1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/query.py 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
- Coverage   73.22%   73.22%   -0.01%     
==========================================
  Files         226      226              
  Lines       21000    21007       +7     
==========================================
+ Hits        15378    15383       +5     
- Misses       5622     5624       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the 0.4.12 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants