Fix bug caching requests with pyvo request_hooks#3586
Open
emellega wants to merge 1 commit intoastropy:mainfrom
Open
Fix bug caching requests with pyvo request_hooks#3586emellega wants to merge 1 commit intoastropy:mainfrom
emellega wants to merge 1 commit intoastropy:mainfrom
Conversation
0e21009 to
ae746f1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
==========================================
- Coverage 73.22% 73.22% -0.01%
==========================================
Files 226 226
Lines 21000 21007 +7
==========================================
+ Hits 15378 15383 +5
- Misses 5622 5624 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we migrated the ESASky module to use EsaTap/PyVO we noticed some weird errors for some of our requests that we didn't have before. When downloading images through the ESASky module we got Pyvo errors saying that we didn't conform to the TAP spec. It turns out that when we do a deep copy on the response (which contains the request hooks) during caching, it triggers something within Pyvo to do that validation.
I guess this is more of a workaround around something that is broken within pyvo rather than an actual bug fix. Let me know if you find this acceptable, or if you would rather see a proper fix within pyvo.