Skip to content

Fix bug caching requests with pyvo request_hooks #3586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emellega wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −6
Open

Fix bug caching requests with pyvo request_hooks #3586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions astroquery/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,22 @@
__all__ = ['BaseVOQuery', 'BaseQuery', 'QueryWithLogin']


def to_cache(response, cache_file):
def to_cache(original_response, cache_file):
log.debug("Caching data to {0}".format(cache_file))

response = copy.deepcopy(response)
if hasattr(response, 'request'):
for key in tuple(response.request.hooks.keys()):
del response.request.hooks[key]
hooks = None
if hasattr(original_response, 'request'):
hooks = original_response.request.hooks
del original_response.request.hooks
if hasattr(original_response, 'history'):
for r in original_response.history:
if hasattr(r, 'request'):
del r.request.hooks
response_copy = copy.deepcopy(original_response)
if hooks:
original_response.request.hooks = hooks
with open(cache_file, "wb") as f:
pickle.dump(response, f, protocol=4)
pickle.dump(response_copy, f, protocol=4)


def _replace_none_iterable(iterable):
Expand Down
Loading