fix: Wyre widget crash on Buy button (#179)#310
Closed
rovidev95 wants to merge 6 commits into
Closed
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ed, WithdrawFromPrivate Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ffith#179) Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
Author
|
@TimDaub Friendly bump — all PRs are MERGEABLE and waiting for review:
Happy to split #311 into per-issue PRs if that helps review. Algora claims in each PR body. Thanks! |
4 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #179 —
Cannot read property 'Widget' of undefinedon wyre.xdai.io.Root cause:
wyre.jscapturedwindow.Wyreat module load time, beforewidget-loader.jsfinished loading.Fix:
window.Wyrelazily insidedisplayWidget()falseso UI resets loading stateTest plan
Stacks on top of rimble-ui work in #309 (same
rimbranch).— RoviDev (@rovidev95)