Skip to content

feat(Core/Scripting): OnPlayerResurrect allow changing of applySickness#25353

Open
sogladev wants to merge 2 commits intoazerothcore:masterfrom
sogladev:feat-applysickness-hook
Open

feat(Core/Scripting): OnPlayerResurrect allow changing of applySickness#25353
sogladev wants to merge 2 commits intoazerothcore:masterfrom
sogladev:feat-applysickness-hook

Conversation

@sogladev
Copy link
Copy Markdown
Member

@sogladev sogladev commented Apr 2, 2026

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

allow modification of applySickness to allow/disallow core application of Rez Sickness

mod-ale

AI-assisted Pull Requests

Important

While the use of AI tools when preparing pull requests is not prohibited, contributors must clearly disclose when such tools have been used and specify the model involved.

Contributors are also expected to fully understand the changes they are submitting and must be able to explain and justify those changes when requested by maintainers.

  • AI tools (e.g. ChatGPT, Claude, or similar) were used entirely or partially in preparing this pull request. Please specify which tools were used, if any.

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

allow modification of `applySickness` to allow/disallow core application
of Rez Sickness
@sogladev sogladev marked this pull request as ready for review April 2, 2026 21:09
Copilot AI review requested due to automatic review settings April 2, 2026 21:09
@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the player resurrection scripting hook so scripts can control whether the core applies Resurrection Sickness, enabling modules to opt-out of the default sickness behavior.

Changes:

  • Changed OnPlayerResurrect hook parameter applySickness from bool to bool& so scripts can modify it.
  • Updated the PlayerScript virtual method signature accordingly.
  • Updated the ScriptMgr::OnPlayerResurrect implementation to propagate the reference through hook dispatch.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/server/game/Scripting/ScriptMgr.h Updates the ScriptMgr hook signature to take bool& applySickness.
src/server/game/Scripting/ScriptDefines/PlayerScript.h Updates the PlayerScript virtual hook signature to take bool& applySickness.
src/server/game/Scripting/ScriptDefines/PlayerScript.cpp Updates ScriptMgr hook implementation to pass applySickness by reference through CALL_ENABLED_HOOKS.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants