fix: 修正 syncFiles 并发限制与等待，确保全部下载完成#4
Open
sdjnmxd wants to merge 2 commits intobangbang93:masterfrom
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a critical bug in the file synchronization logic where async download jobs were created but never awaited, causing the function to return prematurely before downloads completed.
- Refactored the file download loop to properly collect async jobs and await their completion
- Added
awaitAll()import to support waiting for all concurrent downloads - Changed from
forEachpattern tomap+awaitAll()pattern for proper async handling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+96
to
+110
| val jobs = missingFiles.map { file -> | ||
| async { | ||
| sema.withPermit { | ||
| try { | ||
| downloadFile(file) | ||
| logger.debug { "Downloaded: ${file.path}" } | ||
| } catch (e: Exception) { | ||
| logger.error(e) { "Failed to download ${file.path}" } | ||
| throw e | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| jobs.awaitAll() |
There was a problem hiding this comment.
Inconsistent indentation: the new code uses tabs while the rest of the file uses spaces (4 spaces per indentation level). Please convert the tabs to spaces to match the existing code style.
Suggested change
| val jobs = missingFiles.map { file -> | |
| async { | |
| sema.withPermit { | |
| try { | |
| downloadFile(file) | |
| logger.debug { "Downloaded: ${file.path}" } | |
| } catch (e: Exception) { | |
| logger.error(e) { "Failed to download ${file.path}" } | |
| throw e | |
| } | |
| } | |
| } | |
| } | |
| jobs.awaitAll() | |
| val jobs = missingFiles.map { file -> | |
| async { | |
| sema.withPermit { | |
| try { | |
| downloadFile(file) | |
| logger.debug { "Downloaded: ${file.path}" } | |
| } catch (e: Exception) { | |
| logger.error(e) { "Failed to download ${file.path}" } | |
| throw e | |
| } | |
| } | |
| } | |
| } | |
| jobs.awaitAll() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.