Skip to content

fix: 修正 syncFiles 并发限制与等待，确保全部下载完成 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdjnmxd wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: 修正 syncFiles 并发限制与等待，确保全部下载完成 #4

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441fddd
fix: 修正 syncFiles 并发限制与等待，确保全部下载完成
sdjnmxd Oct 28, 2025
1bdbb90
fix: 将制表符缩进改为4个空格，与其他文件保持一致
sdjnmxd Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/main/kotlin/com/bangbang93/openbmclapi/agent/service/ClusterService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import io.socket.client.Socket
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.async
import kotlinx.coroutines.awaitAll
import kotlinx.coroutines.sync.Semaphore
import kotlinx.coroutines.sync.withPermit
import kotlinx.serialization.decodeFromByteArray
Expand Down Expand Up @@ -92,19 +93,21 @@ class ClusterService(

val sema = Semaphore(syncConfig.concurrency)

missingFiles.forEach { file ->
sema.withPermit {
async {
try {
downloadFile(file)
logger.debug { "Downloaded: ${file.path}" }
} catch (e: Exception) {
logger.error(e) { "Failed to download ${file.path}" }
throw e
}
}
}
}
val jobs = missingFiles.map { file ->
async {
sema.withPermit {
try {
downloadFile(file)
logger.debug { "Downloaded: ${file.path}" }
} catch (e: Exception) {
logger.error(e) { "Failed to download ${file.path}" }
throw e
}
}
}
}

jobs.awaitAll()
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent indentation: the new code uses tabs while the rest of the file uses spaces (4 spaces per indentation level). Please convert the tabs to spaces to match the existing code style.

Suggested change
val jobs = missingFiles.map { file ->
async {
sema.withPermit {
try {
downloadFile(file)
logger.debug { "Downloaded: ${file.path}" }
} catch (e: Exception) {
logger.error(e) { "Failed to download ${file.path}" }
throw e
}
}
}
}
jobs.awaitAll()
val jobs = missingFiles.map { file ->
async {
sema.withPermit {
try {
downloadFile(file)
logger.debug { "Downloaded: ${file.path}" }
} catch (e: Exception) {
logger.error(e) { "Failed to download ${file.path}" }
throw e
}
}
}
}
jobs.awaitAll()

Copilot uses AI. Check for mistakes.

logger.info { "Sync completed: ${missingFiles.size} files" }
}
Expand Down