Skip to content

Add indexed_by=maybe to cards#2827

Merged
flavorjones merged 3 commits intobasecamp:mainfrom
robzolkos:indexed-by-maybe
Apr 14, 2026
Merged

Add indexed_by=maybe to cards#2827
flavorjones merged 3 commits intobasecamp:mainfrom
robzolkos:indexed-by-maybe

Conversation

@robzolkos
Copy link
Copy Markdown
Collaborator

@robzolkos robzolkos commented Apr 9, 2026

Summary

This adds indexed_by=maybe to GET /:account_slug/cards so API clients can ask the cards endpoint for awaiting-triage / "Maybe?" cards.

What wasn't possible before

Before this change, GET /:account_slug/cards supported indexed_by=closed and indexed_by=not_now, but there was no equivalent way to ask that same endpoint for awaiting-triage cards.

Clients that wanted "Maybe?" cards had to either:

  • fetch a broader /cards result set and filter client-side for cards with no workflow column, or
  • switch to the board-scoped stream endpoint instead of using /cards

That made the cards endpoint asymmetric: Done and Not Now were directly filterable there, but Maybe? was not.

What this PR adds

  • support indexed_by=maybe on GET /:account_slug/cards
  • route that filter to awaiting-triage cards
  • document the new indexed_by value
  • add model and controller coverage

Example

  • GET /:account_slug/cards?indexed_by=maybe

Copilot AI review requested due to automatic review settings April 9, 2026 20:56
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@robzolkos robzolkos changed the title Add indexed_by=maybe for awaiting-triage cards Add indexed_by=maybe to cards Apr 9, 2026
@robzolkos robzolkos requested a review from flavorjones April 9, 2026 21:20
@flavorjones
Copy link
Copy Markdown
Member

@robzolkos Looks good! Needs to be rebased, though.

@robzolkos
Copy link
Copy Markdown
Collaborator Author

@flavorjones rebased and we have a transient test issue which is fixed by #2838 Once that one is merged (if ok) I'll rebase again - test should pass.

@flavorjones flavorjones merged commit abd5956 into basecamp:main Apr 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants