Skip to content

Add indexed_by=maybe to cards #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flavorjones merged 3 commits into from
Apr 14, 2026
+12 −1
Merged

Add indexed_by=maybe to cards #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd7507d
Add indexed_by=maybe to cards
robzolkos Apr 9, 2026
295c60f
Retry CI
robzolkos Apr 14, 2026
82c96ed
Retry CI again
robzolkos Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/card.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ class Card < ApplicationRecord
when "stalled" then stalled
when "postponing_soon" then postponing_soon
when "closed" then closed
when "maybe" then awaiting_triage
when "not_now" then postponed.latest
when "golden" then golden
when "draft" then drafted
Expand Down
2 changes: 1 addition & 1 deletion docs/api/sections/cards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ __Query Parameters:__
| `closer_ids[]` | Filter by user ID(s) who closed the cards |
| `card_ids[]` | Filter to specific card ID(s) |
| `column_ids[]` | Filter by workflow column ID(s) |
| `indexed_by` | Filter by: `all` (default), `closed`, `not_now`, `stalled`, `postponing_soon`, `golden` |
| `indexed_by` | Filter by: `all` (default), `maybe`, `closed`, `not_now`, `stalled`, `postponing_soon`, `golden` |
| `sorted_by` | Sort order: `latest` (default), `newest`, `oldest` |
| `assignment_status` | Filter by assignment status: `unassigned` |
| `creation` | Filter by creation date: `today`, `yesterday`, `thisweek`, `lastweek`, `thismonth`, `lastmonth`, `thisyear`, `lastyear` |
Expand Down
7 changes: 7 additions & 0 deletions test/controllers/cards_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ class CardsControllerTest < ActionDispatch::IntegrationTest
assert_equal [ cards(:logo).number, cards(:layout).number, cards(:text).number ].sort, @response.parsed_body.pluck("number").sort
end

test "index as JSON can filter by maybe index" do
get cards_path(format: :json), params: { indexed_by: "maybe" }
assert_response :success

assert_equal [ cards(:buy_domain).number ], @response.parsed_body.pluck("number")
end

test "create a new draft" do
assert_difference -> { Card.count }, 1 do
post board_cards_path(boards(:writebook))
Expand Down
3 changes: 3 additions & 0 deletions test/models/filter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ class FilterTest < ActiveSupport::TestCase
filter = users(:david).filters.new indexed_by: "closed"
assert_equal [ cards(:shipping) ], filter.cards

filter = users(:david).filters.new indexed_by: "maybe", board_ids: [ boards(:writebook).id ]
assert_equal [ cards(:buy_domain) ], filter.cards

cards(:shipping).postpone
filter = users(:david).filters.new indexed_by: "not_now"
assert_includes filter.cards, cards(:shipping)
Expand Down