[DNM] WS-2370 - New nav dual script languages#13915
Draft
[DNM] WS-2370 - New nav dual script languages#13915
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables dual-script services to participate in the “new nav” rollout and updates their chameleon brand SVGs to match the new navigation designs.
Changes:
- Adds
serbian,ukchina,uzbek, andzhongwentoSERVICES_WITH_NEW_NAV. - Updates chameleon logo SVG definitions for the dual-script services (including updated
viewboxsettings).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/components/Navigation/config.ts | Expands the new-nav allowlist to include dual-script services. |
| src/app/components/ThemeProvider/chameleonLogos/serbian.tsx | Updates Serbian chameleon logo SVG and sets explicit viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/ukchina.tsx | Replaces UK China chameleon logo SVG content and sets explicit viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/uzbek.tsx | Updates Uzbek chameleon logo SVG and sets explicit viewbox. |
| src/app/components/ThemeProvider/chameleonLogos/zhongwen.tsx | Updates Zhongwen chameleon logo SVG and sets explicit viewbox. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2370
Summary
Allows dual script services to render the new two-tier navigation
Code changes
SERVICES_WITH_NEW_NAVto include dual script servicesgetcommands referencing the older navigation layoutTesting
Useful Links