Dolphin rc f722

[DolphinRC]

Pull-Request requirements

Mandatory Review for All New Flight Controllers

• All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
• Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

• All hardware must adhere to the Manufacturer Design Guidelines.
• Poor hardware designs will not be accepted, as outlined in the Requirements for the Submission of New and Updated Targets.
• Adhere to the [Config Target Guidance] https://betaflight.com/docs/development/manufacturer/config-target-guidance
• To avoid costly issues and delays, we strongly encourage consulting with Betaflight developers early in your design process and providing schematics for review before producing hardware.

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

• Pull-Request only from a custom branch, not master.
• Replace this text with details of your own.

Checklist (✓/✕, or y/n)

• passed Betaflight team's schematics review
• passed hardware samples testing
• follows guidelines
• follows connector standards
• flight tested
• comments/issues resolved

Summary by CodeRabbit

• New Features

  • Added support for the DolphinRC DOLPHINRC_F722 flight controller board, including full hardware configuration and pin mappings for sensors, peripherals, and interfaces.

• Documentation

  • Updated the supported manufacturers list to include DolphinRC with contact URL.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds DolphinRC to the manufacturer table and introduces a new board configuration header for DOLPHINRC_F722 with MCU/board IDs, enabled peripherals, pin/timer mappings, and meter/blackbox defaults.

Changes

DolphinRC F722 Board Support

Layer / File(s)	Summary
Manufacturer registration Manufacturers.md	Added DOLP manufacturer ID entry for DolphinRC with contact URL.
Board configuration header configs/DOLPHINRC_F722/config.h	New board config header defining MCU/board identifiers, feature flags (accel, gyro, barometer, flash, MAX7456), motor/LED/UART/I2C/SPI/ADC pin assignments, TIMER_PIN_MAPPING, and blackbox/current/voltage meter defaults.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• osirisinferi
• ot0tot
• haslinghuis

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description still contains the template boilerplate with all checklist items unchecked and placeholder text not replaced with device-specific details, failing to meet submission requirements.	Replace template text with specific hardware details, fill in the checklist items indicating compliance status, and remove the 'Replace this text' placeholder guidance.
Title check	❓ Inconclusive	The title 'Dolphin rc f722' is overly generic and lacks specificity; it simply names the product without conveying what was changed or added to the codebase.	Use a more descriptive title such as 'Add DolphinRC F722 flight controller configuration' to clearly indicate the main change being introduced.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[osirisinferi]

Please read the Manufacturer Design Guidelines as clearly stated in the template. You appear to have not done so.

Also, please see my reply on your issue opened earlier about joining the Discord server for schematic review.

[coderabbitai]

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@configs/DolphinRC_F722/config.h`:
- Line 27: The MANUFACTURER_ID macro currently uses the literal DolphinRC;
update the definition of MANUFACTURER_ID to use the registered manufacturer code
"DOLP" instead (replace the identifier DolphinRC with the string/code DOLP in
the `#define` MANUFACTURER_ID line) so metadata matches the registered
manufacturer ID.
- Around line 80-84: TIMER_PIN_MAP entries reference undefined macros
MOTOR5_PIN, MOTOR6_PIN, MOTOR7_PIN, and MOTOR8_PIN (and optionally
LED_STRIP_PIN); fix by either defining those pin macros in this config (e.g.,
add MOTOR5_PIN..MOTOR8_PIN definitions matching the board wiring) or
remove/replace the TIMER_PIN_MAP lines with the correct existing pin macros;
update the TIMER_PIN_MAP(...) calls (lines with TIMER_PIN_MAP(4..7,
MOTOR5_PIN..MOTOR8_PIN)) to use the newly defined MOTORx_PIN symbols or the
appropriate existing pin identifiers so compilation succeeds.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2b1a7202-f5c9-42b6-a945-1aef82bdc152

📥 Commits

Reviewing files that changed from the base of the PR and between 6703db5 and c833dda.

📒 Files selected for processing (2)

• Manufacturers.md
• configs/DolphinRC_F722/config.h

[osirisinferi]

Suggested change

	#define ADC1_DMA_OPT 0
	#define TIMUP8_DMA_OPT 0
	#define TIMUP3_DMA_OPT 0
	#define ADC_INSTANCE ADC3
	#define ADC3_DMA_OPT 1

AFAIK TIMUPx_DMA_OPT isn't used for F7. Bitbanged DShot is default anyway.

ADC3 required due to DMA conflicts with TIM8 on ADC1, PC0 and PC1 support all three ADCs.

[osirisinferi]

Is this FC going to be part of a stack?

[coderabbitai]

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

♻️ Duplicate comments (1)

configs/DolphinRC_F722/config.h (1)

25-25: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Directory name must be uppercase to match board name.

The board name macro is correctly uppercase (DOLPHINRC_F722), but the directory name configs/DolphinRC_F722/ remains mixed-case. Per past review feedback, the directory should be renamed to configs/DOLPHINRC_F722/ to maintain consistency with Betaflight naming conventions.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@configs/DolphinRC_F722/config.h` at line 25, The directory name currently
uses mixed case; rename the directory named "DolphinRC_F722" to "DOLPHINRC_F722"
so it exactly matches the BOARD_NAME macro (DOLPHINRC_F722) defined in config.h;
update any references to that directory in build configs or includes to use the
new uppercase directory name.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Manufacturers.md`:
- Line 47: The DOLP manufacturer entry is out of alphabetical order; remove the
existing line "|DOLP|DolphinRC|https://www.dolphinrc.com/|" from after DYST and
insert that exact entry between the DIAT and DRCL entries so the list remains
alphabetized (respecting the special-top-4 exception).

---

Duplicate comments:
In `@configs/DolphinRC_F722/config.h`:
- Line 25: The directory name currently uses mixed case; rename the directory
named "DolphinRC_F722" to "DOLPHINRC_F722" so it exactly matches the BOARD_NAME
macro (DOLPHINRC_F722) defined in config.h; update any references to that
directory in build configs or includes to use the new uppercase directory name.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1143fa97-f9d4-4b6d-98e3-f98408f51a8e

📥 Commits

Reviewing files that changed from the base of the PR and between a36e439 and 3ededda.

📒 Files selected for processing (2)

• Manufacturers.md
• configs/DolphinRC_F722/config.h

[osirisinferi]

Please use the ISO basic Latin alphabet order to sort the list (on the first column). Not just on the first letter, but on the entire 4 character manufacturer ID.

[osirisinferi]

Some last (I think/hope) requests for changes from my part.