add DSK320 gyros to foxeer targets#1105
Conversation
added #define USE_ACCGYRO_LSM6DSK320X to current foxeer models and added build keys to the targets that meet current requriemnets
WalkthroughThree FOXEER flight controller board configurations are extended with LSM6DSK320X accelerometer and gyroscope sensor support via a compile-time macro. Two boards additionally receive updated supported-target metadata blocks with reference commit hash and date information. ChangesLSM6DSK320X sensor enablement across FOXEER boards
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@configs/FOXEERF405V2/config.h`:
- Line 34: FOXEERF405V2 is missing the "SUPPORTED TARGET" metadata block that
the other FOXEER boards have; either add the same metadata block (with the
appropriate reference hashes and date) to configs/FOXEERF405V2/config.h or
explicitly document that the board is intentionally excluded; locate the config
by the symbol/name USE_ACCGYRO_LSM6DSK320X and insert a SUPPORTED TARGET
metadata block matching the format used in FOXEERF722V4 and FOXEERH743V2 (or add
a comment above the `#define` explaining why no metadata is provided) so the PR
consistently reflects whether the target meets the build-key requirements.
In `@configs/FOXEERF722V4/config.h`:
- Around line 21-26: The DATE metadata in the header comment currently reads
"DATE: 2025-12-01" and should be clarified or updated; either change the DATE
field to the PR/modification date (e.g., "DATE: 2026-05-19") or add an explicit
note (e.g., "ORIGINAL_CERT_DATE: 2025-12-01; LAST_MODIFIED: 2026-05-19") so it's
clear whether the value refers to the original board certification or the
current change — update the comment block accordingly where the DATE line
appears.
In `@configs/FOXEERH743V2/config.h`:
- Around line 22-27: The DATE field in the header comment block (the /* ...
DATE: 2025-12-01 */ metadata) is stale relative to this PR; either update the
DATE value to the current modification/PR date (e.g., 2026-05-19) or add a
clarifying comment that the DATE represents the original board certification
date and include a separate field like LAST_MODIFIED with the PR date; modify
the comment block in configs/FOXEERH743V2/config.h accordingly so the intent is
explicit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 31233d6f-49ab-4b62-9ff6-c0ecf7aaec02
📒 Files selected for processing (3)
configs/FOXEERF405V2/config.hconfigs/FOXEERF722V4/config.hconfigs/FOXEERH743V2/config.h
| #define USE_GYRO_SPI_MPU6000 | ||
| #define USE_GYRO_SPI_MPU6500 | ||
| #define USE_GYRO_SPI_ICM42688P | ||
| #define USE_ACCGYRO_LSM6DSK320X |
There was a problem hiding this comment.
Inconsistency: FOXEERF405V2 lacks metadata block.
The other two FOXEER boards in this PR (FOXEERF722V4 and FOXEERH743V2) receive "SUPPORTED TARGET" metadata blocks with reference hashes and dates, but FOXEERF405V2 does not. The PR description mentions "Added build keys for targets that meet the current requirements" — clarify whether FOXEERF405V2 intentionally does not meet those requirements, or if the metadata block was omitted in error.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@configs/FOXEERF405V2/config.h` at line 34, FOXEERF405V2 is missing the
"SUPPORTED TARGET" metadata block that the other FOXEER boards have; either add
the same metadata block (with the appropriate reference hashes and date) to
configs/FOXEERF405V2/config.h or explicitly document that the board is
intentionally excluded; locate the config by the symbol/name
USE_ACCGYRO_LSM6DSK320X and insert a SUPPORTED TARGET metadata block matching
the format used in FOXEERF722V4 and FOXEERH743V2 (or add a comment above the
`#define` explaining why no metadata is provided) so the PR consistently reflects
whether the target meets the build-key requirements.
|
|
||
| /* | ||
| SUPPORTED TARGET - THANK YOU | ||
| REFERENCE: sha256_d21ad5220a3e870ab430532a54672fe1871728dc5f4ea49d544a417c3ad6da3c | ||
| DATE: 2025-12-01 | ||
| */ |
There was a problem hiding this comment.
Backdated metadata: DATE is 2025-12-01 but PR is from 2026-05-19.
The metadata block shows a date of 2025-12-01, which is over five months before this PR was created. Clarify whether this date represents the original board certification date or if it should be updated to reflect the current modification date.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@configs/FOXEERF722V4/config.h` around lines 21 - 26, The DATE metadata in the
header comment currently reads "DATE: 2025-12-01" and should be clarified or
updated; either change the DATE field to the PR/modification date (e.g., "DATE:
2026-05-19") or add an explicit note (e.g., "ORIGINAL_CERT_DATE: 2025-12-01;
LAST_MODIFIED: 2026-05-19") so it's clear whether the value refers to the
original board certification or the current change — update the comment block
accordingly where the DATE line appears.
| /* | ||
| SUPPORTED TARGET - THANK YOU | ||
| REFERENCE: sha256_0a3515d028fa96e28361619fc00701b426bfaa43b38d9302c3cd6838bd81f4aa | ||
| DATE: 2025-12-01 | ||
| */ | ||
|
|
There was a problem hiding this comment.
Backdated metadata: DATE is 2025-12-01 but PR is from 2026-05-19.
The metadata block shows a date of 2025-12-01, which is over five months before this PR was created. Clarify whether this date represents the original board certification date or if it should be updated to reflect the current modification date.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@configs/FOXEERH743V2/config.h` around lines 22 - 27, The DATE field in the
header comment block (the /* ... DATE: 2025-12-01 */ metadata) is stale relative
to this PR; either update the DATE value to the current modification/PR date
(e.g., 2026-05-19) or add a clarifying comment that the DATE represents the
original board certification date and include a separate field like
LAST_MODIFIED with the PR date; modify the comment block in
configs/FOXEERH743V2/config.h accordingly so the intent is explicit.
3 participants
added #define USE_ACCGYRO_LSM6DSK320X
to current Foxeer models and added build keys to the targets that meet current requirements
Summary by CodeRabbit