Skip to content

add DSK320 gyros to foxeer targets #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sugaarK wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add DSK320 gyros to foxeer targets #1105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configs/FOXEERF405V2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
#define USE_GYRO_SPI_MPU6000
#define USE_GYRO_SPI_MPU6500
#define USE_GYRO_SPI_ICM42688P
#define USE_ACCGYRO_LSM6DSK320X
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistency: FOXEERF405V2 lacks metadata block.

The other two FOXEER boards in this PR (FOXEERF722V4 and FOXEERH743V2) receive "SUPPORTED TARGET" metadata blocks with reference hashes and dates, but FOXEERF405V2 does not. The PR description mentions "Added build keys for targets that meet the current requirements" — clarify whether FOXEERF405V2 intentionally does not meet those requirements, or if the metadata block was omitted in error.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@configs/FOXEERF405V2/config.h` at line 34, FOXEERF405V2 is missing the
"SUPPORTED TARGET" metadata block that the other FOXEER boards have; either add
the same metadata block (with the appropriate reference hashes and date) to
configs/FOXEERF405V2/config.h or explicitly document that the board is
intentionally excluded; locate the config by the symbol/name
USE_ACCGYRO_LSM6DSK320X and insert a SUPPORTED TARGET metadata block matching
the format used in FOXEERF722V4 and FOXEERH743V2 (or add a comment above the
`#define` explaining why no metadata is provided) so the PR consistently reflects
whether the target meets the build-key requirements.

#define USE_BARO
#define USE_BARO_DPS310
#define USE_BARO_BMP280
Expand Down
7 changes: 7 additions & 0 deletions configs/FOXEERF722V4/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
*
* If not, see <http://www.gnu.org/licenses/>.
*/

/*
SUPPORTED TARGET - THANK YOU
REFERENCE: sha256_d21ad5220a3e870ab430532a54672fe1871728dc5f4ea49d544a417c3ad6da3c
DATE: 2025-12-01
*/
Comment on lines +21 to +26
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Backdated metadata: DATE is 2025-12-01 but PR is from 2026-05-19.

The metadata block shows a date of 2025-12-01, which is over five months before this PR was created. Clarify whether this date represents the original board certification date or if it should be updated to reflect the current modification date.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@configs/FOXEERF722V4/config.h` around lines 21 - 26, The DATE metadata in the
header comment currently reads "DATE: 2025-12-01" and should be clarified or
updated; either change the DATE field to the PR/modification date (e.g., "DATE:
2026-05-19") or add an explicit note (e.g., "ORIGINAL_CERT_DATE: 2025-12-01;
LAST_MODIFIED: 2026-05-19") so it's clear whether the value refers to the
original board certification or the current change — update the comment block
accordingly where the DATE line appears.


#pragma once

Expand All @@ -32,6 +38,7 @@
#define USE_ACC_SPI_MPU6000
#define USE_GYRO_SPI_ICM42688P
#define USE_ACC_SPI_ICM42688P
#define USE_ACCGYRO_LSM6DSK320X
#define USE_BARO
#define USE_BARO_DPS310
#define USE_BARO_BMP280
Expand Down
7 changes: 7 additions & 0 deletions configs/FOXEERH743V2/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@
* If not, see <http://www.gnu.org/licenses/>.
*/

/*
SUPPORTED TARGET - THANK YOU
REFERENCE: sha256_0a3515d028fa96e28361619fc00701b426bfaa43b38d9302c3cd6838bd81f4aa
DATE: 2025-12-01
*/

Comment on lines +22 to +27
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Backdated metadata: DATE is 2025-12-01 but PR is from 2026-05-19.

The metadata block shows a date of 2025-12-01, which is over five months before this PR was created. Clarify whether this date represents the original board certification date or if it should be updated to reflect the current modification date.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@configs/FOXEERH743V2/config.h` around lines 22 - 27, The DATE field in the
header comment block (the /* ... DATE: 2025-12-01 */ metadata) is stale relative
to this PR; either update the DATE value to the current modification/PR date
(e.g., 2026-05-19) or add a clarifying comment that the DATE represents the
original board certification date and include a separate field like
LAST_MODIFIED with the PR date; modify the comment block in
configs/FOXEERH743V2/config.h accordingly so the intent is explicit.

#pragma once

#define FC_TARGET_MCU STM32H743
Expand All @@ -34,6 +40,7 @@
#define USE_ACC_SPI_MPU6000
#define USE_ACC_SPI_MPU6500
#define USE_ACC_SPI_ICM42688P
#define USE_ACCGYRO_LSM6DSK320X
#define USE_BARO
#define USE_BARO_DPS310
#define USE_FLASH
Expand Down
Loading