Add previously overlooked configurations for an old target #929

[aocodarc]

Add previously overlooked configurations for an old target #929

Pull-Request requirements

Mandatory Review for All New Flight Controllers

• All new flight controllers must undergo the Betaflight review process, regardless of whether they use an existing target.
• Manufacturers may reuse the same target for multiple designs, but each new hardware release must be reviewed before approval.

Hardware Compliance Requirements

• All hardware must adhere to the Manufacturer Design Guidelines.
• Poor hardware designs will not be accepted, as outlined in the Requirements for the Submission of New and Updated Targets.
• Adhere to the [Config Target Guidance] https://betaflight.com/docs/development/manufacturer/config-target-guidance
• To avoid costly issues and delays, we strongly encourage consulting with Betaflight developers early in your design process and providing schematics for review before producing hardware.

These measures help maintain high standards and ensure compatibility within the Betaflight ecosystem.

If you have any questions or need guidance, feel free to reach out to the Betaflight development team.

Housekeeping

• Pull-Request only from a custom branch, not master.
• Replace this text with details of your own.

Checklist (✓/✕, or y/n)

• passed Betaflight team's schematics review
• passed hardware samples testing
• follows guidelines
• follows connector standards
• flight tested
• comments/issues resolved

Summary by CodeRabbit

• New Features
  • Enabled PinIO and PinIOBox support for AOCODARCG473V1 device configuration, providing enhanced pin-based input/output capabilities and extended device functionality options.
  • Configured PinIO1 with dedicated pin mapping and control settings to enable improved device control, user customization, and operational flexibility.

[coderabbitai]

Walkthrough

The AOCODARCG473V1 board configuration header is extended to enable PinIO support with two feature macros and three PinIO1 hardware configuration macros that map the pin to PB2, the box to 40, and set configuration mode to 1.

Changes

AOCODARCG473V1 PinIO1 Support

Layer / File(s)	Summary
PinIO1 feature enablement and hardware mapping configs/AOCODARCG473V1/config.h	PinIO feature flags USE_PINIO and USE_PINIOBOX are enabled. PinIO1 hardware is configured with pin mapping to PB2, box 40, and configuration mode 1.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• betaflight/config#1073: Adds PINIO1 hardware configuration macros to board config files, directly related to this PR's PinIO1 mapping.
• betaflight/config#1058: Enables PinIO and defines PINIO1 configuration across multiple board targets, matching the same pattern of PinIO1 setup.
• betaflight/config#929: Initially introduces the AOCODARCG473V1 target configuration; this PR extends that same file with PinIO1 support.

Suggested labels

Ready To Merge

Suggested reviewers

• ot0tot
• haslinghuis

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding previously overlooked configurations for an old flight controller target.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[osirisinferi]

USE_PINIO is a user configurable option, so should not be defined in the target. And USE_PINIOBOX is automatically defined when USE_PINIO is defined in src/main/target/common_post.h.

(Although that same common_post.h also defines USE_PINIO if it's not already set by the user if any PINIOx_BOX is defined.)

[aocodarc]

Sorry, Now I understand these two lines, So these two lines need delete or just not merge? what I can do next?

[osirisinferi]

Does this PINIO do something specific? If so, please also define BOX_USER1_NAME with the appropriate value.

[ot0tot]

This pin was not connected in the provided schematic, and no pad or connector was indicated for PINIO.

[aocodarc]

This pin was not connected in the provided schematic, and no pad or connector was indicated for PINIO.

yes, this pin we add for camera switch, our customer need this function