Skip to content

Add previously overlooked configurations for an old target #929 #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aocodarc wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

Add previously overlooked configurations for an old target #929 #1109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions configs/AOCODARCG473V1/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
#define USE_BARO_MS5611
#define USE_GYRO_CLKIN
#define USE_MAG
#define USE_PINIO
#define USE_PINIOBOX
Comment on lines +43 to +44
Copy link
Copy Markdown
Contributor

@osirisinferi osirisinferi May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

USE_PINIO is a user configurable option, so should not be defined in the target. And USE_PINIOBOX is automatically defined when USE_PINIO is defined in src/main/target/common_post.h.

(Although that same common_post.h also defines USE_PINIO if it's not already set by the user if any PINIOx_BOX is defined.)

Copy link
Copy Markdown
Contributor Author

@aocodarc aocodarc May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Now I understand these two lines, So these two lines need delete or just not merge? what I can do next?


#define MOTOR1_PIN PA0
#define MOTOR2_PIN PA1
Expand Down Expand Up @@ -81,6 +83,7 @@

#define ADC_VBAT_PIN PB0
#define ADC_CURR_PIN PB1
#define PINIO1_PIN PB2

#define TIMER_PIN_MAPPING \
TIMER_PIN_MAP( 0, MOTOR1_PIN, 2, 0) \
Expand All @@ -101,6 +104,8 @@
#define GYRO_1_SPI_INSTANCE SPI1
#define MAX7456_SPI_INSTANCE SPI2
#define FLASH_SPI_INSTANCE SPI3
#define PINIO1_BOX 40
#define PINIO1_CONFIG 1

#define DEFAULT_BLACKBOX_DEVICE BLACKBOX_DEVICE_FLASH
#define DEFAULT_DSHOT_BURST DSHOT_DMAR_OFF
Expand Down
Loading