Skip to content

add TBS_LUCID_H7_OEM#1110

Open
bkleiner wants to merge 1 commit into
betaflight:masterfrom
tbs-fpv:add-lucid-h7-oem
Open

add TBS_LUCID_H7_OEM#1110
bkleiner wants to merge 1 commit into
betaflight:masterfrom
tbs-fpv:add-lucid-h7-oem

Conversation

@bkleiner
Copy link
Copy Markdown
Contributor

@bkleiner bkleiner commented May 29, 2026

Checklist (✓/✕, or y/n)

  • passed Betaflight team's schematics review
  • passed hardware samples testing
  • follows guidelines
  • follows connector standards
  • flight tested
  • comments/issues resolved

Summary by CodeRabbit

  • New Features
    • Added full support for the TBS LUCID H7 OEM flight controller: integrated inertial and barometric sensors, SD card logging, beeper and LED control, configurable motor/servo outputs and timers, multiple serial ports with receiver selection, analog current/voltage metering defaults, and user-configurable I/O/box mappings for telemetry and peripherals.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Walkthrough

A new Betaflight board configuration header is added for the TBS_LUCID_H7_OEM target. The file specifies the STM32H743 MCU, enables SPI-connected sensors and barometer, enables SDCARD, and defines GPIO mappings for motors, servos, LEDs, UART, I2C, SPI, ADC, SDIO, and PINIO, plus timer routing, DMA/ADC options, meter defaults, user box mappings, and serial RX settings.

Changes

TBS_LUCID_H7_OEM Board Configuration

Layer / File(s) Summary
MCU, board identity, features, and primary GPIO/SPI/UART mappings
configs/TBS_LUCID_H7_OEM/config.h
Board header preamble, target MCU and board identity, sensor and feature enables (SPI accelerometer/gyro, barometer, SDCARD, beeper), beeper/motor/servo/LED GPIO assignments, UART2-8 pin mappings, and SPI1/3/4 plus gyro CS/EXTI/SPI selections.
ADC, SDIO, PINIO and timer-to-pin routing
configs/TBS_LUCID_H7_OEM/config.h
ADC input pin mappings, SDIO pin definitions, PINIO1-3 auxiliary IO mappings, and TIMER_PIN_MAPPING routing timers/channels to motors, servos, LED strip, and beeper.
DMA/ADC options, meter defaults, user boxes and serial RX selection
configs/TBS_LUCID_H7_OEM/config.h
DMA option constants for ADC and TIMUP, DEFAULT_BLACKBOX_DEVICE set to SDCARD, default current/voltage meter sources and scaling, user box name and PINIO config macros, and SERIALRX_PROVIDER/SERIALRX_UART selection.

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • betaflight/config#1061: Adds another STM32H743 board config.h with similar macros, pin/timer mapping, and peripheral configuration.
  • betaflight/config#983: Adds a new board config header under configs/* with comparable feature flags and pin/timer mappings.
  • betaflight/config#838: Adds sensor and barometer macros in a board config.h following the same header pattern.

Suggested reviewers

  • haslinghuis
  • ot0tot
  • blckmn
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description includes only the checklist from the template but lacks all mandatory content sections including hardware compliance requirements, design guidelines adherence, and manufacturing guidance. Complete the description by adding details about hardware compliance, design guidelines adherence, schematics review status, and testing results before the checklist section.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'add TBS_LUCID_H7_OEM' is concise, directly related to the main change, and clearly indicates the addition of a new board configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread configs/TBS_LUCID_H7_OEM/config.h Outdated
@bkleiner bkleiner force-pushed the add-lucid-h7-oem branch from 2a73e86 to e24cc44 Compare May 29, 2026 10:32
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@configs/TBS_LUCID_H7_OEM/config.h`:
- Around line 29-37: The macros for the IMU model are inconsistent: replace or
align the incorrect USE_ACCGYRO_ICM42686P macro so it matches the rest of the
config (USE_ACC_SPI_ICM42688P and USE_GYRO_SPI_ICM42688P) by changing
USE_ACCGYRO_ICM42686P to USE_ACCGYRO_ICM42688P, or alternatively add the
corresponding gyro macro for the 86P variant if the 86P is intentional; update
only the macro name(s) (USE_ACCGYRO_ICM42686P, USE_ACC_SPI_ICM42688P,
USE_GYRO_SPI_ICM42688P) so acc+gyro reference the same IMU model.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b76815df-7f65-4f7c-8657-a424e9b07b1f

📥 Commits

Reviewing files that changed from the base of the PR and between 2a73e86 and e24cc44.

📒 Files selected for processing (1)
  • configs/TBS_LUCID_H7_OEM/config.h

Comment thread configs/TBS_LUCID_H7_OEM/config.h
@sugaarK sugaarK added the Partner Program this pr is for a target from the partner program and will automatically get tier 1 status label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner Program this pr is for a target from the partner program and will automatically get tier 1 status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants