Feathers text input widget#23645
Conversation
alice-i-cecile
added
C-Feature
alice-i-cecile
added
S-Needs-Review
alice-i-cecile
added
X-Uncontroversial
| }); | ||
| } | ||
|
|
||
| fn update_text_input_focus( |
There was a problem hiding this comment.
Can we hook into the existing FocusIndicator infrastructure here?
There was a problem hiding this comment.
I can't, for two reasons:
- This detects a focused descendant rather than a focused ancestor
- The highlight uses an inset rect rather than an outline
There was a problem hiding this comment.
Kk, that's fine, but leave a comment to this effect please :)
There was a problem hiding this comment.
Comment added; I suppose it's possible to generalize FocusIndicator in some way, but it seems like it would be complicated. In CSS this would be handled by the :focus-within pseudo-class.
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
There's a swapped match-on-bool here that's blocking. Rest is just cleanup.
The text becomes invisible when selected. |
This is a known issue, which is being addressed in another PR. |
| Children [ | ||
| ( | ||
| text_input(TextInputProps { | ||
| max_characters: Some(9), |
There was a problem hiding this comment.
This lets users enter a nine digit number, I'd have:
| max_characters: Some(9), | |
| max_characters: Some(8), |
and prepend the "#" symbol with a Text entity
There was a problem hiding this comment.
For now, I'm going by what Srgb::hex and Srgb::to_hex do, which is to include the # in the string.
kfc35
added
S-Ready-For-Final-Review
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
5 participants
Objective
Feathers text input widget
Part of #19236
Solution
Build a wrapper around
EditableTextthat has feathers styling and themes.Testing
WiP