conditionally disable tests on miri for taking way too long#23677
Open
janis-bhm wants to merge 1 commit intobevyengine:mainfrom
Open
conditionally disable tests on miri for taking way too long#23677janis-bhm wants to merge 1 commit intobevyengine:mainfrom
janis-bhm wants to merge 1 commit intobevyengine:mainfrom
Conversation
janis-bhm
added
A-Build-System
Zeophlite
approved these changes
Apr 6, 2026
Contributor
If we made Windows build faster, we'd still need this |
alice-i-cecile
approved these changes
Apr 6, 2026
alice-i-cecile
added
A-ECS
alice-i-cecile
added
the
D-Straightforward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The PR CI takes a long time, particularly because of miri. maybe disable some tests on miri?
related to #20818 (partitioning seems to lead to about 20 6-8minute slices if running on ubuntu, but miri also doesn't have a cached build, I'm not sure how much that could help; 20x 6 minutes is like a lot compared to 1x 25-30 minutes which I think was the reason @mockersf stopped pursuing that direction)
Solution
I've found 3 tests which take quite a bit longer than the rest. These are pretty low hanging fruits for reducing the time miri takes to test, HOWEVER I'm not sure if these tests benefit from miri (especially the toctou one) and should definitely run on miri.
Edit: looks like this doesn't result in any meaningful difference because now the windows build is the bottleneck