Expand examples for NestedQuery to show how to delegate a QueryData impl#23686
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Apr 9, 2026
Merged
Expand examples for NestedQuery to show how to delegate a QueryData impl#23686alice-i-cecile merged 2 commits intobevyengine:mainfrom
NestedQuery to show how to delegate a QueryData impl#23686alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
alice-i-cecile
approved these changes
Apr 6, 2026
kfc35
approved these changes
Apr 8, 2026
Co-authored-by: Kevin Chen <chen.kevin.f@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Demonstrate how to use
NestedQueryto implement relational queries.There is more design work required before making first-party relational queries, but third-party implementations are already possible using
NestedQuery. The documentation does not make it clear how to actually implement them, though, and the only real example is buried in the PR description of #21557.Solution
Expand the examples for
NestedQueryto include the implementation of aParent<D>relational query. Keep one example that uses#[derive(QueryData)]with a method on the generatedItemtype, but also add an example with a manualQueryDataimpl that delegates everything.