Skip to content

Make Skybox not break rendering if its image is default or 2D.#23689

Open
kpreid wants to merge 1 commit intobevyengine:mainfrom
kpreid:skybox-validation
Open

Make Skybox not break rendering if its image is default or 2D.#23689
kpreid wants to merge 1 commit intobevyengine:mainfrom
kpreid:skybox-validation

Conversation

@kpreid
Copy link
Copy Markdown
Contributor

@kpreid kpreid commented Apr 6, 2026

Objective

Solution

If the image is detected to be invalid, have prepare_skybox_bind_groups ignore it (and warn once).

Testing

Manually tested that examples/3d/skybox.rs works if the initial skybox has the default image.

If there’s a good way to programmatically test things like this, let me know — I didn’t see any similar tests to emulate.

@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Apr 6, 2026
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 6, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 6, 2026
@alice-i-cecile alice-i-cecile added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Crash A sudden unexpected crash S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

2 participants