Open
Conversation
alice-i-cecile
requested changes
Apr 7, 2026
Member
alice-i-cecile
left a comment
There was a problem hiding this comment.
I like this solution but it needs more docs. I left suggestions about where to put them.
alice-i-cecile
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Built in collection types like
Option<T>andVec<T>use the blanketFromTemplateimpl for types that implementDefault+Clone. This works in the common case whereTis a normal Default + Clone type. This breaks down whenThas custom template logic (ex: it is something likeHandle<T>, which manually implements Template/FromTemplate, or it is something that derivesFromTemplate). These cases currently require a solid chunk of boilerplate and knowledge about what is happening under the hood:Solution
This adds the
BuiltInTemplatetrait, which serves essentially the same function asFromTemplate, but does not have a blanket implementation forDefault+Clonetypes. It requires a manual implementation.This PR adds
BuiltInTemplateimplementations forOptionandVec.When deriving
FromTemplate, fields can opt in to usingBuiltInTemplateinstead ofFromTemplatelike this:Of course ideally
image: Option<Handle<Image>>would "just work". What we're seeing here is the "price" of transparently supporting any type that implementsDefault+Clonein BSN. That is a big win, and I consider the papercut in this case to be "worth it".