fix(events): emit PendingManagerCancelled event when replacing pending proposal - #157
Open
rushikeshgarad2024-dev wants to merge 2 commits into
Conversation
…nager proposal (closes boundlessfi#137)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Closes #137
Reference:
docs/threat-model.mdv1.0, Spoof.7 (planned hardening).Problem
Previously, calling
propose_managerwhen aPendingManagerwas already active would overwrite the storage record without emittingPendingManagerCancelled. An observer watching contract events would see two consecutiveManagerProposedevents without an explicit cancellation for the superseded proposal, leading to timeline ambiguity.Solution
propose_managerincontracts/events/src/event_ops.rsto check if a pending manager is already set forevent_idviastorage::get_pending_manager(env, event_id).is_some().evt::PendingManagerCancelled { event_id }.publish(env)immediately prior to writing the replacementPendingManagerand publishingManagerProposed.propose_manager_emits_cancellation_when_replacing_pending_proposaltocontracts/events/src/tests/cross_contract.rsto verify replacement semantics and successful subsequent acceptance.