Skip to content

fix(events): emit PendingManagerCancelled event when replacing pending proposal #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rushikeshgarad2024-dev wants to merge 2 commits into
base: testnet
Choose a base branch
from
Open

fix(events): emit PendingManagerCancelled event when replacing pending proposal #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6285153
fix(events): emit PendingManagerCancelled when replacing a pending ma…
rushikeshgarad2024-dev Sep 13, 2026
3d7bd4a
test(events): add unit test verifying propose_manager replacement seq…
rushikeshgarad2024-dev Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/events/src/event_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,10 @@ pub fn propose_manager(env: &Env, event_id: u64, new_manager: Address) -> Result
let event = storage::get_event(env, event_id).ok_or(Error::EventNotFound)?;
resolve_manager(env, event_id, &event.owner).require_auth();

if storage::get_pending_manager(env, event_id).is_some() {
evt::PendingManagerCancelled { event_id }.publish(env);
}

let expires_at = env
.ledger()
.sequence()
Expand Down
16 changes: 16 additions & 0 deletions contracts/events/src/tests/cross_contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,6 +1076,22 @@ fn manager_can_be_rotated_via_propose_accept() {
assert_eq!(ctx.events.get_manager(&id), manager2);
}

#[test]
fn propose_manager_emits_cancellation_when_replacing_pending_proposal() {
let ctx = setup();
let manager1 = Address::generate(&ctx.env);
let id = create_bounty_with_manager(&ctx, &manager1);
assert!(ctx.events.get_pending_manager(&id).is_some());

let manager2 = Address::generate(&ctx.env);
ctx.events.propose_manager(&id, &manager2);
let pending = ctx.events.get_pending_manager(&id).unwrap();
assert_eq!(pending.target, manager2);

ctx.events.accept_manager(&id);
assert_eq!(ctx.events.get_manager(&id), manager2);
}

#[test]
fn cancel_pending_manager_vetoes_a_proposal() {
let ctx = setup();
Expand Down