allow thor 1.4 - #131
Merged
pokonski merged 6 commits intoNov 20, 2025
Merged
Conversation
eglitobias
reviewed
Oct 28, 2025
Co-authored-by: Tobias <88370686+eglitobias@users.noreply.github.com>
eglitobias
reviewed
Oct 28, 2025
| @@ -1,3 +1,3 @@ | |||
| module Gush | |||
| VERSION = '4.2.0'.freeze | |||
| VERSION = '4.2.1'.freeze | |||
There was a problem hiding this comment.
Suggested change
| VERSION = '4.2.1'.freeze | |
| VERSION = '4.3.0'.freeze |
I would say it's not only a patch as we do not support activejob 6 anymore
|
Please also update the https://github.com/chaps-io/gush/blob/master/.github/workflows/ruby.yml#L29 and add Rails 8.1 |
|
As it includes an important security update, it should get merged soon ! |
paresharma
added a commit
to seefleet/gush
that referenced
this pull request
Nov 5, 2025
Monitor upstream: chaps-io#131
Contributor
|
Merging soon would be best since it's addressing a security issue. |
Contributor
|
Dropping support for Rails < 7.0 is definitely a major version bump |
allows us to upgrade thor beyond '1.3' to address a security issue in older versions.
Contributor
Author
Contributor
|
Thank you! Looks good, I'll release it ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thor < 1.4 has a security issue, see: GHSA-mqcp-p2hv-vw6x
This address the issue: #130
I needed to make ActiveJob minimally 7.0 in order to load the Logger properly