Skip to content

allow thor 1.4 #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pokonski merged 6 commits into from
Nov 20, 2025
Merged

allow thor 1.4 #131

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3fba336
upgrade ActiveJob to minimally 7.0 which allows thor 1.4
btihen Aug 12, 2025
09f1309
remove comment and move to Merge / Pull Request
btihen Aug 12, 2025
be8ec78
update versions
btihen Aug 13, 2025
8a56e1a
Update gush.gemspec
btihen Oct 28, 2025
fbb366f
chore: update tests and rails versions
btihen Oct 28, 2025
fa7ff19
new major version number: dropping Rails 5.x
btihen Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
source 'https://rubygems.org'
gemspec

rails_version = ENV['RAILS_VERSION'] || '< 7.0'
rails_version = ENV['RAILS_VERSION'] || '>= 7.0.0'
rails_version = "~> #{rails_version}" if rails_version =~ /^\d/
gem 'activejob', rails_version

Expand Down
4 changes: 2 additions & 2 deletions gush.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]
spec.required_ruby_version = '>= 3.0.0'

spec.add_dependency "activejob", ">= 6.1.0", "< 8.1.0"
spec.add_dependency "activejob", ">= 7.0.0", "< 8.1.0"
Comment thread
btihen marked this conversation as resolved.
Outdated
spec.add_dependency "concurrent-ruby", "~> 1.0"
spec.add_dependency "multi_json", "~> 1.11"
spec.add_dependency "redis", ">= 3.2", "< 6"
Expand All @@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
spec.add_dependency "graphviz", "~> 1.2"
spec.add_dependency "terminal-table", ">= 1.4", "< 3.1"
spec.add_dependency "paint", "~> 2.2"
spec.add_dependency "thor", ">= 0.19", "< 1.3"
spec.add_dependency "thor", ">= 0.19", "< 1.5"
spec.add_dependency "launchy", "~> 2.4"
spec.add_development_dependency "bundler"
spec.add_development_dependency "rake", "~> 12"
Expand Down
2 changes: 1 addition & 1 deletion lib/gush/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Gush
VERSION = '4.2.0'.freeze
VERSION = '4.2.1'.freeze

@eglitobias eglitobias Oct 28, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VERSION = '4.2.1'.freeze
VERSION = '4.3.0'.freeze

I would say it's not only a patch as we do not support activejob 6 anymore

@btihen btihen Nov 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

end