[testing] Move D/I Mem tests to MemorySpec#5263
Conversation
jackkoenig
left a comment
There was a problem hiding this comment.
Why should these be moved?
|
SRAM library depends on D/I so we can't support that in Scala 3 until D/I is implemented. We can't move D/I tests until this is out of it |
But you can't move the D/I tests until D/I is implemented anyway right? |
|
Yeah but then I can't move D/I tests until SRAM is also implemented, which will be a separate patch after |
|
Ok so my plan was to move D/I with its tests together in the same patch, which is how I've been doing major feature PRs for Scala 3. But now that I think about it that's going to be quite a lot of work for D/I because of all this intermixing in its testing. What I can do instead is to make PRs for everything before moving any of the tests |
In anticipation of Scala 3 D/I
Contributor Checklist
docs/src?Type of Improvement
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.6.x,5.x, or6.xdepending on impact, API modification or big change:7.0)?Enable auto-merge (squash)and clean up the commit message.Create a merge commit.