Skip to content

POC for turboskipping a build#1375

Draft
skitterm wants to merge 2 commits into
mainfrom
steven/turboskip-spike
Draft

POC for turboskipping a build#1375
skitterm wants to merge 2 commits into
mainfrom
steven/turboskip-spike

Conversation

@skitterm

@skitterm skitterm commented Jun 3, 2026

Copy link
Copy Markdown
Member

Super-basic CLI changes needed to get turboskipping POC to work on the backend. Mainly this just skips further CLI steps after publishing the build.

📦 Published PR as canary version: 17.2.1--canary.1375.26916509418.0

✨ Test out this PR locally via:

npm install chromatic@17.2.1--canary.1375.26916509418.0
# or 
yarn add chromatic@17.2.1--canary.1375.26916509418.0

@skitterm skitterm added patch Auto: Increment the patch version when merged DO NOT MERGE Block: Prevent merging this PR release Auto: Create a `latest` release when merged labels Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

📦 Package Size: 7112 KB
✅ Compared to main: 0 KB 14391bc (7112 KB)

@skitterm skitterm removed the DO NOT MERGE Block: Prevent merging this PR label Jun 3, 2026
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.15%. Comparing base (c25fdc8) to head (6b98b3b).
⚠️ Report is 78 commits behind head on main.

Files with missing lines Patch % Lines
node-src/tasks/verify/verifyBuild.ts 33.33% 2 Missing ⚠️
node-src/tasks/verify/publishBuild.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   80.85%   81.15%   +0.29%     
==========================================
  Files         226      228       +2     
  Lines        4226     4292      +66     
  Branches     1210     1230      +20     
==========================================
+ Hits         3417     3483      +66     
- Misses        695      696       +1     
+ Partials      114      113       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +30 to +35
export const publishSkipped = (ctx: Context) => ({
status: 'error',
title: `Verifying your ${buildType(ctx)}`,
output: 'Build skipped, not publishing',
});

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused for now.

Comment on lines +125 to +128
if (onlyStoryFiles.length === 0) {
transitionTo(success, true)(ctx, task);
return;
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not correct, but was trying to get the console output to early-exit.

Comment on lines +60 to +63

if (publishedBuild.status === 'SKIPPED') {
ctx.skip = true;
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to skip future steps now that we know the build should be turboskipped.

@codykaup codykaup self-assigned this Jun 11, 2026
@codykaup codykaup marked this pull request as draft June 12, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants