Skip to content

POC for turboskipping a build #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
skitterm wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

POC for turboskipping a build #1375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43e6a0b
POC for turboskipping a build
skitterm Jun 3, 2026
6b98b3b
Remove nonexistent reference
skitterm Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions node-src/tasks/verify/publishBuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,8 @@ export const publishBuild = async (ctx: Context) => {
setExitCode(ctx, exitCodes.BUILD_FAILED, false);
throw new Error(publishFailed(ctx).output);
}

if (publishedBuild.status === 'SKIPPED') {
ctx.skip = true;
}
Comment on lines +60 to +63

@skitterm skitterm Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to skip future steps now that we know the build should be turboskipped.

};
4 changes: 4 additions & 0 deletions node-src/tasks/verify/verifyBuild.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ export const verifyBuild = async (ctx: Context, task: Task) => {
// It's not possible to set both --only-changed and --only-story-files and/or --only-story-names
// onlyStoryFiles may be passed directly, or calculated via --only-changed
if (onlyStoryFiles) {
if (onlyStoryFiles.length === 0) {
transitionTo(success, true)(ctx, task);
return;
}
Comment on lines +125 to +128

@skitterm skitterm Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not correct, but was trying to get the console output to early-exit.

transitionTo(runOnlyFiles)(ctx, task);
}
if (onlyStoryNames) {
Expand Down
6 changes: 6 additions & 0 deletions node-src/ui/tasks/verify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@ export const publishFailed = (ctx: Context) => ({
output: 'Failed to publish build',
});

export const publishSkipped = (ctx: Context) => ({
status: 'error',
title: `Verifying your ${buildType(ctx)}`,
output: 'Build skipped, not publishing',
});

Comment on lines +30 to +35

@skitterm skitterm Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unused for now.

export const runOnlyFiles = (ctx: Context) => ({
status: 'pending',
title: 'Starting partial build',
Expand Down
Loading