Skip to content

Disable eigen debug for CUDA device code#11

Merged
smuzaffar merged 1 commit intocms-externals:cms/master/c1d637433e3b3f9012b226c2c9125c494b470ae6from
fwyzard:change_EIGEN_CUDACC_to_EIGEN_CUDA_ARCH
Feb 11, 2026
Merged

Disable eigen debug for CUDA device code#11
smuzaffar merged 1 commit intocms-externals:cms/master/c1d637433e3b3f9012b226c2c9125c494b470ae6from
fwyzard:change_EIGEN_CUDACC_to_EIGEN_CUDA_ARCH

Conversation

@fwyzard
Copy link
Copy Markdown

@fwyzard fwyzard commented Feb 10, 2026

EIGEN_CUDACC is defined also when nvcc compiles host code, while EIGEN_CUDA_ARCH is only define when compiling device code.

EIGEN_CUDACC is defined also when nvcc compiles host code, while EIGEN_CUDA_ARCH
is only define when compiling device code.
@cmsbuild
Copy link
Copy Markdown

A new Pull Request was created by @fwyzard for branch cms/master/c1d637433e3b3f9012b226c2c9125c494b470ae6.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown

cmsbuild commented Feb 10, 2026

cms-bot internal usage

@smuzaffar
Copy link
Copy Markdown

test parameters:

  • enable = gpu
  • gpu = nvidia

@smuzaffar
Copy link
Copy Markdown

please test for CMSSW_16_1_PY312_X

@smuzaffar smuzaffar merged commit b25e86a into cms-externals:cms/master/c1d637433e3b3f9012b226c2c9125c494b470ae6 Feb 11, 2026
10 of 11 checks passed
@smuzaffar
Copy link
Copy Markdown

smuzaffar commented Feb 11, 2026

thanks @fwyzard , this looks better than #10

@cmsbuild
Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f68b7f/51246/summary.html
COMMIT: bcfbef0
CMSSW: CMSSW_16_1_PY312_X_2026-02-09-2300/el8_amd64_gcc13
Additional Tests: GPU,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-externals/eigen-git-mirror/11/51246/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f68b7f/51246/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f68b7f/51246/git-merge-result

Comparison Summary

The workflows 2025.0010001, 2024.0050001, 2023.0020001, 2022.0030001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 224 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 17166 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3977722
  • DQMHistoTests: Total failures: 26611
  • DQMHistoTests: Total nulls: 136
  • DQMHistoTests: Total successes: 3950955
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.559999999999999 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 2023.0020001 ): 20.484 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2023.0020001 ): 0.539 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2023.0020001 ): -0.043 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.0020001 ): -0.005 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0050001 ): 3.309 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2024.0050001 ): -0.171 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2024.0050001 ): 0.082 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0050001 ): 0.082 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2025.0010001 ): -17.961 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 2025.0010001 ): -0.445 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 2025.0010001 ): ...
  • Checked 222 log files, 193 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants