Skip to content

Update ROCm to version 7.0.0#10084

Closed
fwyzard wants to merge 1 commit intocms-sw:IB/CMSSW_16_0_X/masterfrom
fwyzard:IB/CMSSW_16_0_X/master_rocm70
Closed

Update ROCm to version 7.0.0#10084
fwyzard wants to merge 1 commit intocms-sw:IB/CMSSW_16_0_X/masterfrom
fwyzard:IB/CMSSW_16_0_X/master_rocm70

Conversation

@fwyzard
Copy link
Copy Markdown
Contributor

@fwyzard fwyzard commented Sep 17, 2025

For the changes since ROCm 6.4.3, see the ROCm 7.0.0 release notes.

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @fwyzard for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 17, 2025

cms-bot internal usage

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 17, 2025

enable gpu

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 17, 2025

test parameters:

  • full_cmssw = true
  • enable = gpu

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 17, 2025

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48188/summary.html
COMMIT: f34cbf9
CMSSW: CMSSW_16_0_X_2025-09-16-2300/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10084/48188/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48188/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48188/git-merge-result

Build

I found compilation error when building:

Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestOneRadixSortROCmAsync/libalpakaTestOneRadixSortROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestOneToManyAssocROCmAsync/libalpakaTestOneToManyAssocROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestPrefixScanROCmAsync/libalpakaTestPrefixScanROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestPrefixScanROCmAsync/libalpakaTestPrefixScanROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestPrefixScanROCmAsync/libalpakaTestPrefixScanROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1920: tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestPrefixScanROCmAsync/libalpakaTestPrefixScanROCmAsync_rocm.a] Error 1
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestRadixSortROCmAsync/libalpakaTestRadixSortROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaTestSimpleVectorROCmAsync/libalpakaTestSimpleVectorROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaInterface/test/alpakaWorkDivisionROCmAsync/libalpakaWorkDivisionROCmAsync_rocm.a to productstore area:
Copying tmp/el8_amd64_gcc12/src/HeterogeneousCore/AlpakaMath/test/alpakaTestDeltaPhiROCmAsync/libalpakaTestDeltaPhiROCmAsync_rocm.a to productstore area:
>> Entering Package RecoTracker/MkFitCore


@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

ROCm 7.0 does not implement warpSize as constexpr 🤦🏻

See e.g. ROCm/ROCm#4121 (comment) .

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

please test with cms-sw/cmssw#48947

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48208/summary.html
COMMIT: f34cbf9
CMSSW: CMSSW_16_0_X_2025-09-18-1100/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10084/48208/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48208/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c646d/48208/git-merge-result

Comparison Summary

Summary:

AMD_MI300X Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

NVIDIA_L40S Comparison Summary

Summary:

NVIDIA_T4 Comparison Summary

Summary:

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 19, 2025

hold

The tests look good, but we should run some benchmarks before merging the PR.

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @fwyzard
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Sep 19, 2025
@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Oct 3, 2025

Superseded by ROCm 7.0.1 bugfix release.

@fwyzard fwyzard closed this Oct 3, 2025
@fwyzard fwyzard deleted the IB/CMSSW_16_0_X/master_rocm70 branch October 3, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants