Skip to content

Update the compile-time warp size constant for ROCm 7.0#48947

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
fwyzard:update_warpsize_for_ROCm_7.0
Sep 19, 2025
Merged

Update the compile-time warp size constant for ROCm 7.0#48947
cmsbuild merged 1 commit intocms-sw:masterfrom
fwyzard:update_warpsize_for_ROCm_7.0

Conversation

@fwyzard
Copy link
Copy Markdown
Contributor

@fwyzard fwyzard commented Sep 18, 2025

PR description:

ROCm 7.0 no longer defines the warp size as a compile-time constant.
Work around it using preprocessor macros.

PR validation:

Code compiles with ROCm 7.0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Unlikely to be backported to 15.1.x, unless we need ROCm 7.0 in that release branch.

@cmsbuild
Copy link
Copy Markdown
Contributor

cmsbuild commented Sep 18, 2025

cms-bot internal usage

@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaInterface (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

enable gpu

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

please abort

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

please test

Comment thread HeterogeneousCore/AlpakaInterface/interface/warpsize.h Outdated
@cmsbuild
Copy link
Copy Markdown
Contributor

@cmsbuild
Copy link
Copy Markdown
Contributor

Pull request #48947 was updated. @cmsbuild, @fwyzard, @makortel can you please check and sign again.

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

please test

@cmsbuild
Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b9c20/48207/summary.html
COMMIT: 8d51780
CMSSW: CMSSW_16_0_X_2025-09-18-1100/el8_amd64_gcc12
Additional Tests: GPU,AMD_MI300X,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48947/48207/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3978581
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3978545
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 210 log files, 180 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53486
  • DQMHistoTests: Total failures: 7421
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 46065
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

NVIDIA_T4 Comparison Summary

Summary:

@fwyzard
Copy link
Copy Markdown
Contributor Author

fwyzard commented Sep 18, 2025

+heterogeneous

I guess this is working as intended since all tests pass.

@cmsbuild
Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@ftenchini
Copy link
Copy Markdown

+1

@cmsbuild cmsbuild merged commit 8a0294f into cms-sw:master Sep 19, 2025
30 checks passed
Comment thread HeterogeneousCore/AlpakaInterface/interface/warpsize.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants