Update the compile-time warp size constant for ROCm 7.0#48947
Update the compile-time warp size constant for ROCm 7.0#48947cmsbuild merged 1 commit intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48947/46110 |
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
please abort |
|
please test |
de6c39c to
8d51780
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48947/46116 |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
|
|
+heterogeneous I guess this is working as intended since all tests pass. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
ROCm 7.0 no longer defines the warp size as a compile-time constant.
Work around it using preprocessor macros.
PR validation:
Code compiles with ROCm 7.0.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Unlikely to be backported to 15.1.x, unless we need ROCm 7.0 in that release branch.