Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs#46853
Merged
cmsbuild merged 3 commits intocms-sw:masterfrom Jan 9, 2025
Merged
Removing CUDA/gpu from Pixel code configs and dropping all CUDA wfs#46853cmsbuild merged 3 commits intocms-sw:masterfrom
gpu from Pixel code configs and dropping all CUDA wfs#46853cmsbuild merged 3 commits intocms-sw:masterfrom
Conversation
Contributor
|
cms-bot internal usage |
Contributor
Author
|
Well, apparently already these changes involve many parties. So maybe I'll push the drop of the |
Contributor
Author
|
enable gpu |
Contributor
Author
|
please test |
Contributor
Contributor
|
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @Moanwar, @antoniovilela, @atpathak, @consuegs, @davidlange6, @DickyChant, @fabiocos, @jfernan2, @mandrenguyen, @miquork, @perrotta, @rappoccio, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
assign heterogeneous |
Contributor
Contributor
AdrianoDee
force-pushed
the
remove_cuda_wfs_and_pixel_cfgs
branch
from
5d626de to
77de940
Compare
Contributor
Author
|
Seems not this time, unfortunately. Let me fix the commit history. |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46853/43192
|
Contributor
|
Pull request #46853 was updated. @Martin-Grunewald, @Moanwar, @antoniovilela, @atpathak, @civanch, @cmsbuild, @consuegs, @davidlange6, @emeschi, @fabiocos, @ftorrresd, @fwyzard, @hqucms, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @mmusich, @perrotta, @rappoccio, @smorovic, @srimanob, @subirsarkar can you please check and sign again. |
Contributor
Author
|
please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46853/43193
|
Contributor
|
Pull request #46853 was updated. @Moanwar, @antoniovilela, @atpathak, @consuegs, @davidlange6, @fabiocos, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @perrotta, @rappoccio, @srimanob, @subirsarkar can you please check and sign again. |
Contributor
|
please test |
Contributor
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS Comparison SummarySummary:
GPU Comparison SummarySummary:
|
Contributor
my bad, will fix. |
Contributor
|
@cmsbuild, please test
|
Contributor
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
GPU Comparison SummarySummary:
|
Contributor
Author
|
Thanks @mmusich @cms-sw/alca-l2 @cms-sw/reconstruction-l2 @cms-sw/heterogeneous-l2 @cms-sw/upgrade-l2 this should be ready to go (the last couple of commits were only rebases). |
Contributor
|
+1 |
Contributor
|
+alca
|
Contributor
|
+Upgrade |
Contributor
|
+1 |
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
This was referenced Jan 9, 2025
Merged
makortel
reviewed
Jan 10, 2025
|
|
||
| (alpaka & pp_on_AA & ~phase2_tracker).toModify(siPixelRecHitsPreSplitting, | ||
| cpu = _siPixelRecHitFromSoAAlpakaHIonPhase1.clone( | ||
| (alpaka & pp_on_AA & ~phase2_tracker).toModify(siPixelRecHitsPreSplitting, _siPixelRecHitFromSoAAlpakaHIonPhase1.clone( |
Contributor
There was a problem hiding this comment.
This line should have been
(alpaka & pp_on_AA & ~phase2_tracker).toReplaceWith(siPixelRecHitsPreSplitting, _siPixelRecHitFromSoAAlpakaHIonPhase1.clone(Workflow 160.401 fails in the IB with
Traceback (most recent call last):
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 40, in <module>
run()
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/bin/el8_amd64_gcc12/cmsDriver.py", line 16, in run
configBuilder.prepare()
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 2284, in prepare
self.addStandardSequences()
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 826, in addStandardSequences
getattr(self,"prepare_"+stepName)(stepSpec = getattr(self,stepName+"DefaultSeq"))
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 1743, in prepare_RECO
_,_recoSeq,_ = self.loadDefaultOrSpecifiedCFF(stepSpec,self.RECODefaultCFF)
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 1275, in loadDefaultOrSpecifiedCFF
l=self.loadAndRemember(_cff)
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/Configuration/Applications/python/ConfigBuilder.py", line 354, in loadAndRemember
self.process.load(includeFile)
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/FWCore/ParameterSet/python/Config.py", line 760, in load
module = __import__(moduleName)
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-01-09-2300/src/Configuration/StandardSequences/python/Reconstruction_cff.py", line 8, in <module>
from RecoTracker.Configuration.RecoTracker_cff import *
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-01-09-2300/src/RecoTracker/Configuration/python/RecoTracker_cff.py", line 5, in <module>
from RecoTracker.IterativeTracking.iterativeTk_cff import *
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-01-09-2300/src/RecoTracker/IterativeTracking/python/iterativeTk_cff.py", line 4, in <module>
from RecoTracker.IterativeTracking.InitialStepPreSplitting_cff import *
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-01-09-2300/src/RecoTracker/IterativeTracking/python/InitialStepPreSplitting_cff.py", line 245, in <module>
from RecoLocalTracker.SiPixelRecHits.SiPixelRecHits_cfi import siPixelRecHits
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_15_0_X_2025-01-09-2300/src/RecoLocalTracker/SiPixelRecHits/python/SiPixelRecHits_cfi.py", line 62, in <module>
(alpaka & pp_on_AA & ~phase2_tracker).toModify(siPixelRecHitsPreSplitting, _siPixelRecHitFromSoAAlpakaHIonPhase1.clone(
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/FWCore/ParameterSet/python/Config.py", line 1783, in toModify
Modifier._toModify(obj,func,**kw)
File "/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02871/el8_amd64_gcc12/cms/cmssw/CMSSW_15_0_X_2025-01-08-2300/src/FWCore/ParameterSet/python/Config.py", line 1866, in _toModify
func(obj)
TypeError: 'EDProducer' object is not callable
Contributor
Author
There was a problem hiding this comment.
Thanks Matti, I opened this #47078 to fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This PR proposes:
pixelNtupletFit_cffmodifier.A subsequent step would be to remove the
gpumodifier, but since this involves code from many parties, I prefer to have it separated.