[GCC14] Fix compiler warnings

[iarspider]

PR description:

Title says it all.

PR validation:

Bot tests

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47556/44037

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/GEMDigi (upgrade, simulation)
• L1Trigger/GlobalMuonTrigger (l1)
• L1Trigger/L1TMuonEndCap (l1)
• TrackPropagation/SteppingHelixPropagator (reconstruction)
• Validation/RecoParticleFlow (dqm)

@Moanwar, @aloeliger, @antoniovagnerini, @civanch, @cmsbuild, @epalencia, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @VinInn, @VourMa, @dinyar, @eyigitba, @felicepantaleo, @giovanni-mocellin, @hatakeyamak, @jshlee, @missirol, @mmusich, @mtosi, @rovere, @thomreis, @watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for el8_amd64_gcc14

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47556/44038

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoVertex/PixelVertexFinding/plugins/BuildFile.xml modified in PR(s): Remove legacy CUDA modules for pixel track and vertex reconstruction  #45853

[cmsbuild]

Pull request #47556 was updated. @Moanwar, @aloeliger, @antoniovagnerini, @civanch, @epalencia, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please check and sign again.

[iarspider]

please test for el8_amd64_gcc14

[iarspider]

There are array-bounds warnings: 1, 2, they look false-positive to me.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d4c01/44916/summary.html
COMMIT: 8e4cbef
CMSSW: CMSSW_15_1_X_2025-03-10-2300/el8_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47556/44916/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS deprecated warnings: 4 CMS deprecated warnings found, see summary page for details.

Comparison Summary

Summary:

• You potentially added 214 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 107677 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 4148390
• DQMHistoTests: Total failures: 499361
• DQMHistoTests: Total nulls: 386
• DQMHistoTests: Total successes: 3648623
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 8.831000000000001 KiB( 50 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.415 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 0.938 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 140.045,... ): -0.004 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 141.042 ): 0.043 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.014,... ): 0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.202 ): 0.023 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.408 ): -0.016 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.604 ): 0.090 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 145.713 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 17034.0 ): 3.490 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): ...
• Checked 222 log files, 194 edm output root files, 51 DQM output files
• TriggerResults: found differences in 21 / 49 workflows

[civanch]

+1

why so main problems in regression tests?

[mmusich]

why so main problems in regression tests?

I guess because of the non- regular arch used in the build

please test for el8_amd64_gcc14

[antoniovagnerini]

hi @iarspider , can you confirm that all the failures in the comparison tests are expected from the non-regular arch for the build?

[iarspider]

@antoniovagnerini I'm not an expect in that area, but it's well know that a lot of comparisions fail when comparing with non-default architecture or flavor. Let's start the test for default arch just to be sure.

[iarspider]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3d4c01/44969/summary.html
COMMIT: 8e4cbef
CMSSW: CMSSW_15_1_X_2025-03-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47556/44969/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 52
• DQMHistoTests: Total histograms compared: 4155574
• DQMHistoTests: Total failures: 83
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4155471
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
• Checked 223 log files, 194 edm output root files, 52 DQM output files
• TriggerResults: no differences found

[antoniovagnerini]

+dqm

• spurious differences from unstable WF 24834.911and 29834.999(open issue Non-reproducibility in TrackerPhase2OTL1Track #47071)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[iarspider]

@cms-sw/orp-l2 gentle ping

[mandrenguyen]

+1