Various fixes for heterogeneous utilities#47605
Various fixes for heterogeneous utilities#47605fwyzard wants to merge 3 commits intocms-sw:masterfrom
Conversation
|
cms-bot internal usage |
fwyzard
changed the title
|
type bugfix |
|
enable gpu |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47605/44115
|
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| T const& limit, | ||
| THierarchy const& hierarchy = THierarchy()) -> T { | ||
| T assumed; | ||
| T old = *address; |
There was a problem hiding this comment.
On host parallel backends (that we don't use at the moment) this line is not thread safe (actually, strictly speaking with the default Grids hierarchy level this line is not thread safe even with host serial backend if the same address is accessed concurrently from multiple kernels). To guarantee thread safety on host the load from address would have to be atomic.
There was a problem hiding this comment.
I see.
I will have to think how it can be implemented in a portable way, or specialised for the various backends.
|
Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X. |
|
Milestone for this pull request has been moved to CMSSW_17_0_X. Please open a backport if it should also go in to CMSSW_16_1_X. |
3 participants
PR description:
Add missing
#includes underDataFormats/SoATemplate.Implement
alpaka::atomicIncvariants:Fix a typo in the documentation.
PR validation:
None.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 15.0.x for data taking.