[HGCAL] Add energy loss to Calibration SoA#48187
Closed
IzaakWN wants to merge 3 commits intocms-sw:masterfrom
Closed
[HGCAL] Add energy loss to Calibration SoA#48187IzaakWN wants to merge 3 commits intocms-sw:masterfrom
IzaakWN wants to merge 3 commits intocms-sw:masterfrom
Conversation
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48187/44962 |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48187/44971
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48187/45038 ERROR: Unable to merge PR. See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48187/45038/cms-checkout-topic.log |
2d9fb8a to
50c4dfc
Compare
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48187/45039
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
This was referenced Jul 18, 2025
Contributor
Author
|
Superseded by #48606. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Load energy loss & thickness correction from JSON into calibration SoA. The studies on this for the final geometry are not ready yet, so we decided to not put it in a ConfigDB yet.
PR validation:
...